Page MenuHomePhabricator

Replace usages of Linker::link() and Linker::linkKnown() in extension CentralNotice
Closed, ResolvedPublic

Description

Linker::link() and Linker::linkKnown() functions are deprecated as of MediaWiki 1.28, and the new LinkRenderer is preferred instead.
https://doc.wikimedia.org/mediawiki-core/master/php/classLinker.html

./CentralNotice/includes/BannerRenderer.php:		return Linker::link(
./CentralNotice/includes/CNCampaignPager.php:				return Linker::link(

Event Timeline

Change 677809 had a related patch set uploaded (by Palak199; author: Palak199):

[mediawiki/extensions/CentralNotice@wmf_deploy] Replace:: link with linkRenderer

https://gerrit.wikimedia.org/r/677809

Change 678328 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/extensions/CentralNotice@master] Replace Linker::link with LinkRenderer as the function is deprecated

https://gerrit.wikimedia.org/r/678328

Change 691166 had a related patch set uploaded (by Palak199; author: Palak199):

[mediawiki/extensions/CentralNotice@master] Replace link() function with linkRenderer()

https://gerrit.wikimedia.org/r/691166

Change 677809 abandoned by Aklapper:

[mediawiki/extensions/CentralNotice@wmf_deploy] Replace deprecated Linker::link with linkRenderer

Reason:

Ah, makes sense. Thanks a lot! :) Abandoning as this is superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/ /691166

https://gerrit.wikimedia.org/r/677809

Change 691166 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace link() function with linkRenderer()

https://gerrit.wikimedia.org/r/691166

Change 678328 abandoned by Matěj Suchánek:

[mediawiki/extensions/CentralNotice@master] Replace Linker::link with LinkRenderer as the function is deprecated

Reason:

Done in Ie4edae095269935b4345cf6c26ab02f2b1c76bcd

https://gerrit.wikimedia.org/r/678328