Page MenuHomePhabricator

Replace usages of Linker::link() and Linker::linkKnown() in extension Translate
Closed, ResolvedPublic

Description

Linker::link() and Linker::linkKnown() functions are deprecated as of MediaWiki 1.28, and the new LinkRenderer is preferred instead.
https://doc.wikimedia.org/mediawiki-core/master/php/classLinker.html

./Translate/tag/PageTranslationHooks.php:					$actions[] = Linker::linkKnown( $pageTranslation, $linkDesc, [], $params );
./Translate/tag/PageTranslationHooks.php:				$element = Linker::linkKnown( $specialTranslateTitle, $name, $attribs, $params );
./Translate/tag/PageTranslationHooks.php:				$element = Linker::linkKnown( $subpage, $name, $attribs );
./Translate/tag/PageTranslationHooks.php:						$getlink = Linker::linkKnown(
./Translate/tag/PageTranslationHooks.php:		return Linker::linkKnown(
./Translate/tag/SpecialPageTranslation.php:					$actions[] = Linker::linkKnown(
./Translate/tag/SpecialPageTranslation.php:					$actions[] = Linker::linkKnown(
./Translate/tag/SpecialPageTranslation.php:				$actions[] = Linker::linkKnown(
./Translate/tag/SpecialPageTranslation.php:				$actions[] = Linker::linkKnown(
./Translate/tag/SpecialPageTranslation.php:			$link = Linker::link( $page['title'] );
./Translate/tag/SpecialPageTranslation.php:		$out->setSubtitle( Linker::link( $page->getTitle() ) );
./Translate/utils/StatsTable.php:		$translateGroupLink = Linker::link(
./Translate/utils/TranslateLogFormatter.php:			$link = Linker::link( $title, htmlspecialchars( $text ), [], $parameters );
./Translate/utils/TranslationHelpers.php:	 * @param string $text Link text for Linker::link()

Outcome

The Translate extension no longer uses deprecated methods Linker::link and Linker::linkKnown, allowing them to be removed later once all other uses elsewhere have been removed.

Event Timeline

Change 689039 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] SpecialPageTranslation: Replace deprecated Linker::link*

https://gerrit.wikimedia.org/r/689039

Change 689072 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Replace deprecated use of Linker::link*

https://gerrit.wikimedia.org/r/689072

Change 689039 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] SpecialPageTranslation: Replace deprecated Linker::link*

https://gerrit.wikimedia.org/r/689039

Change 689072 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated use of Linker::link*

https://gerrit.wikimedia.org/r/689072

This has been deployed to translatewiki.net and to production and there hasn't been any reports of issues.