Linker::link() and Linker::linkKnown() functions are deprecated as of MediaWiki 1.28, and the new LinkRenderer is preferred instead.
https://doc.wikimedia.org/mediawiki-core/master/php/classLinker.html
./PageForms/includes/PF_Hooks.php: $text = Linker::linkKnown( $sp->getPageTitle(), $editMsg, [], $linkParams );
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Replace:: Linker::linkKnown with linkRenderer | mediawiki/extensions/PageForms | master | +2 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T149346 Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions | |||
| Resolved | Yaron_Koren | T279363 Replace usages of Linker::link() and Linker::linkKnown() in extension PageForms |
hi @Yaron_Koren, I would like to work on it. Would you please tell me where can I find this repository :)
@Palak199: Hi, please see/click the code project "Tag" in the sidebar; then go to the project tag overview (first entry in the left sidebar).
Many project tag overview pages link to their source repository: https://phabricator.wikimedia.org/project/profile/272/ Thanks! :)
Change 677109 had a related patch set uploaded (by Palak199; author: Palak199):
[mediawiki/extensions/PageForms@master] Replace:: Linker::linkKnown with linkRenderer
Change 677109 abandoned by Yaron Koren:
[mediawiki/extensions/PageForms@master] Replace:: Linker::linkKnown with linkRenderer
Reason:
It's never a good idea to submit a patch with no research or testing.
Change 677109 abandoned by Yaron Koren:
My bad, @Yaron_Koren
I read this documentation
https://doc.wikimedia.org/mediawiki-core/master/php/classLinker.html
and found that information about use of linkKnown and link is given but only one line has been quoted about linkRenderer. Please guide me on where should I find about it.
This site is helpful in finding code examples, as well as underlying classes: https://codesearch.wmcloud.org/search/
Change 677109 restored by Yaron Koren:
[mediawiki/extensions/PageForms@master] Replace:: Linker::linkKnown with linkRenderer
A (simple) example conversion is linked from the parent task: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/303075 . For amending patches, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 - thanks.
Change 677109 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Replace:: Linker::linkKnown with linkRenderer