destructive
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jrbs
	Apr 6 2021, 10:29 PM

Description

When creating or editing a poll in SecurePoll, the buttons to delete questions or options are blue / progressive. They should be red / destructive to match the style guide (since they're destructive in nature).

Screenshot 2021-04-06 at 3.21.27 PM.png (161×156 px, 7 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Changed delete buttons to oo-ui-flaggedElement-destructive (non-primary)	mediawiki/extensions/SecurePoll	master	+6 -0

Customize query in gerrit

Event Timeline

jrbs triaged this task as Low priority.Apr 6 2021, 10:29 PM

jrbs created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2021, 10:29 PM

@jrbs I would like to work on issue.
So after fixing , I need to create new branch with fix or push to any other branch

Hi! I have set up the repo but couldn't locate the exact target. Can u help me with the name of the file in SecurePoll?

Sahilgrewalhere claimed this task.Apr 10 2021, 10:01 AM

Anishdutta11 subscribed.Apr 12 2021, 1:51 PM

Sahilgrewalhere removed Sahilgrewalhere as the assignee of this task.Jun 24 2021, 7:04 AM

Sahilgrewalhere subscribed.

TheresNoTime claimed this task.Jul 15 2021, 1:17 PM

Change 704791 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/SecurePoll@master] Changed delete buttons to oo-ui-flaggedElement-destructive

https://gerrit.wikimedia.org/r/704791

gerritbot added a project: Patch-For-Review.Jul 15 2021, 2:04 PM

TheresNoTime added a project: User-TheresNoTime.Jul 15 2021, 2:07 PM

TheresNoTime moved this task from Backlog to Patch for review on the User-TheresNoTime board.

@Prtksxna: 👋 I've tested @Samtar's change and it LGTM. Could I get your sign off?

In T279487#7248634, @phuedx wrote:

@Prtksxna: 👋 I've tested @Samtar's change and it LGTM. Could I get your sign off?

Thanks for tagging me here! Changing to destructive seems like a good idea, but I think we need to drop the primary. So the button should look something like (image from demo page):

Screenshot 2021-08-02 at 9.18.03 AM.png (134×408 px, 15 KB)

Change 704791 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Changed delete buttons to oo-ui-flaggedElement-destructive (non-primary)

https://gerrit.wikimedia.org/r/704791

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 17 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2021, 12:11 AM

Moving onto the workboard (and straight to QA/Testing) for visibility.

Verified update is done on https://vote.wikimedia.beta.wmflabs.org/

Screen Shot 2021-08-17 at 5.27.21 PM.png (1×2 px, 181 KB)

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.Aug 17 2021, 9:53 PM

• Niharika closed this task as Resolved.Aug 24 2021, 4:05 PM

	F34598691: Screen Shot 2021-08-17 at 5.27.21 PM.png
	Aug 17 2021, 9:52 PM

	F34573349: Screenshot 2021-08-02 at 9.18.03 AM.png
	Aug 2 2021, 3:48 AM

	F34265122: Screenshot 2021-04-06 at 3.21.27 PM.png
	Apr 6 2021, 10:29 PM

`Delete` buttons in Special:SecurePoll/edit should be red / destructiveClosed, ResolvedPublicActions

Description

Details

Event Timeline

`Delete` buttons in Special:SecurePoll/edit should be red / destructive
Closed, ResolvedPublic
Actions