Page MenuHomePhabricator

TheWikipediaLibrary: Add new JSON file containing partner descriptions
Closed, ResolvedPublic

Event Timeline

Change 677559 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Wikipedia Library Card Platform - Add partner descriptions

https://gerrit.wikimedia.org/r/677559

Hi there,

Our team was just discussing this some more today and we realized that we may be able to accommodate the content covered by this change with our existing ugettext workflow. Feel free to de-prioritize this task while we verify. We should know in a week or so.

@jsn.sherman - This approach of having a separate JSON file may work out better for translators. It'll give them more context as to what they are translating. The changes for this are already present in this patch: 677559: Wikipedia Library Card Platform - Add partner descriptions | https://gerrit.wikimedia.org/r/c/translatewiki/+/677559

abi_ changed the task status from Open to Stalled.Apr 8 2021, 3:30 AM

Thank you for the context! We will be meeting today, and I'll be sure that the team knows that this is the preferred method and that the work has already been done on your side.

Okay, we met today and will go ahead with the json workflow. Deploy at your leisure!

abi_ changed the task status from Stalled to Open.Apr 8 2021, 3:15 PM

Just checking in: Anything else we can do to help move things along? we have some dependent updates that are currently awaiting this workflow being in place. Thanks for all your work on this so far!

@jsn.sherman Sorry it is taking longer than usual due to vacations. We should be done from our side early next week.

I think it looks all good from your side. Only thing I noticed is that the strings are quite markup heavy, and I was wondering if that could be reduced a bit by having the <p> tags outside of the message.

I also noticed a few of them uses <em> instead of <strong>, which you may want to check for consistency.

@Nikerabbit Those are reasonable suggestions; I should be able to tackle those on Monday. Thanks!

I've got a pr open for this normalization, but not all the team has had the opportunity to provide feedback yet, so we're not merged yet. I'll update here when we are.

@Nikerabbit the cleaned up descriptions are now merged in. Thanks for the feedback!

Change 677559 merged by jenkins-bot:

[translatewiki@master] Wikipedia Library Card Platform - Add partner descriptions

https://gerrit.wikimedia.org/r/677559

Change 681586 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Wikipedia Library Card Platform: Fix sourcePattern

https://gerrit.wikimedia.org/r/681586

Change 681586 merged by jenkins-bot:

[translatewiki@master] Wikipedia Library Card Platform: Fix sourcePattern

https://gerrit.wikimedia.org/r/681586