Page MenuHomePhabricator
Create Task
Maniphest T279570

Use error message widget on VotePage [L]
Open, In Progress, HighPublic
Actions

Description

The error displayed on the VotePage could do with updating:

image.png (411×619 px, 25 KB)

For STV, this looks more like:

image.png (455×720 px, 43 KB)

Currently the HTML is built in BallotStatus::sp_getHTML. Instead that method could return an OOUI\MessageWidget with type: 'error'.

Note: this change will impact all the error messages for all the different election types. We should make sure nothing breaks with any of those messages when QA-ing this work.

Details

SubjectRepoBranchLines +/-
Use MessageWidget for errors on VotePagemediawiki/extensions/SecurePollmaster+256 -39
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Apr 7 2021, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2021, 6:34 PM
Tchanders mentioned this in T273044: Convert SecurePoll VotePage to use OOUI.Apr 7 2021, 6:38 PM
• Niharika triaged this task as Low priority.Apr 21 2021, 1:55 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.May 26 2021, 2:46 PM
• Niharika raised the priority of this task from Low to Medium.May 26 2021, 2:48 PM
• Niharika updated the task description. (Show Details)Jun 8 2021, 5:58 PM
• Niharika updated the task description. (Show Details)Jun 9 2021, 4:46 PM
ARamirez_WMF renamed this task from Use error message widget on VotePage to Use error message widget on VotePage [L].Jun 9 2021, 4:48 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to Product/Tech backlog on the Anti-Harassment board.Aug 26 2021, 6:30 PM
• Niharika removed a project: Anti-Harassment.Sep 21 2021, 8:47 PM
jrbs subscribed.Jul 30 2022, 12:18 AM

It might also be nice if these messages were shown "live", so that voters don't have to re-select their options if they hit this error.

jrbs raised the priority of this task from Medium to High.Sep 23 2022, 10:33 PM
jrbs moved this task from Backlog to Evaluated on the MediaWiki-extensions-SecurePoll board.
jrbs added a comment.Jan 10 2023, 3:01 PM

Evaluation:

Enhancing the error messages should be straight forward. Live validation may be more effort

jrbs moved this task from Evaluated to Actively working on the MediaWiki-extensions-SecurePoll board.Feb 9 2023, 4:08 PM
gerritbot added a comment.Feb 28 2023, 2:47 PM

Change 892997 had a related patch set uploaded (by Pavlo Yashchenko; author: Pavlo Yashchenko):

[mediawiki/extensions/SecurePoll@master] Use MessageWidget for errors on VotePage

https://gerrit.wikimedia.org/r/892997

gerritbot added a project: Patch-For-Review.Feb 28 2023, 2:47 PM
STran claimed this task.May 8 2023, 11:55 AM
STran added a project: Anti-Harassment (AHaT Sprint 29: The Ikseongwan).May 8 2023, 9:20 PM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 29: The Ikseongwan) board.May 8 2023, 9:23 PM
Tchanders moved this task from AHaT Sprint 29: The Ikseongwan to AHaT Sprint 31 - The Fez on the Anti-Harassment board.May 9 2023, 5:26 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 31 - The Fez); removed Anti-Harassment (AHaT Sprint 29: The Ikseongwan).
Tchanders moved this task from AHaT Sprint 31 - The Fez to AHaT Sprint 32 - Baseball Cap on the Anti-Harassment board.Jun 6 2023, 2:14 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment (AHaT Sprint 31 - The Fez).
• Niharika removed a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Jun 20 2023, 5:53 PM
jsn.sherman changed the task status from Open to In Progress.Fri, Mar 29, 1:58 PM
jsn.sherman reassigned this task from STran to pyashchenko.
jsn.sherman added a project: Moderator-Tools-Team (Kanban).
jsn.sherman moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.
jsn.sherman added a subscriber: STran.
jsn.sherman removed pyashchenko as the assignee of this task.Fri, Mar 29, 2:02 PM
jsn.sherman added a subscriber: pyashchenko.
jsn.sherman edited subscribers, added: jsn.sherman; removed: pyashchenko.Fri, Mar 29, 2:07 PM

Apologies for the phabricator spam, everyone!

jsn.sherman moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Fri, Mar 29, 4:24 PM
Samwalton9-WMF moved this task from Reviewed (waiting for changes) to Code review on the Moderator-Tools-Team (Kanban) board.Tue, Apr 2, 4:18 PM
jsn.sherman assigned this task to Miriamin.Wed, Apr 3, 6:09 PM
jsn.sherman moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Fri, Apr 5, 2:35 PM
Samwalton9-WMF moved this task from Reviewed (waiting for changes) to Code review on the Moderator-Tools-Team (Kanban) board.Thu, Apr 11, 2:38 PM
jsn.sherman moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Fri, Apr 12, 4:47 PM
jsn.sherman moved this task from Reviewed (waiting for changes) to Done on the Moderator-Tools-Team (Kanban) board.Wed, Apr 17, 2:34 PM
gerritbot added a comment.Wed, Apr 17, 2:37 PM

Change #892997 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Use MessageWidget for errors on VotePage

https://gerrit.wikimedia.org/r/892997

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Wed, Apr 17, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, Apr 17, 3:31 PM
Samwalton9-WMF removed a project: Moderator-Tools-Team (Kanban).EditedThu, Apr 25, 4:10 PM
Samwalton9-WMF subscribed.

Should be live on vote.wiki for QA.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL