Page MenuHomePhabricator
Create Task
Maniphest T279600

Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface
Closed, ResolvedPublic
Actions

Description

Rrported by @Pols12 in T96701#6974622: Inserting a non-breaking space in 2017 Wikitext Editor (using your operating system's keyboard shortcut since T96701, or using the upcoming feature from T53045) makes the cursor leave the surface, and pop up a wikitext conversion dialog.

T279600.webm496 KBDownload

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (ef0a3a720)mediawiki/extensions/VisualEditormaster+1 -1
Avoid unnecessary wikitext conversion when inserting NBSP in source modeVisualEditor/VisualEditormaster+7 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Apr 7 2021, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2021, 9:48 PM
matmarex mentioned this in T96701: VE silently alters non-breaking spaces into normal spaces.Apr 7 2021, 9:48 PM
gerritbot added a comment.Apr 7 2021, 10:04 PM

Change 677666 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Avoid unnecessary wikitext conversion when inserting NBSP in source mode

https://gerrit.wikimedia.org/r/677666

gerritbot added a project: Patch-For-Review.Apr 7 2021, 10:04 PM
matmarex claimed this task.Apr 7 2021, 10:04 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
matmarex added a project: VisualEditor.Apr 7 2021, 10:10 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex updated the task description. (Show Details)Apr 7 2021, 10:17 PM
Pols12 awarded a token.Apr 7 2021, 10:23 PM
gerritbot added a comment.Apr 13 2021, 7:48 PM

Change 677666 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Avoid unnecessary wikitext conversion when inserting NBSP in source mode

https://gerrit.wikimedia.org/r/677666

gerritbot added a comment.Apr 13 2021, 7:59 PM

Change 678936 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ef0a3a720)

https://gerrit.wikimedia.org/r/678936

gerritbot added a comment.Apr 13 2021, 8:24 PM

Change 678936 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ef0a3a720)

https://gerrit.wikimedia.org/r/678936

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 13 2021, 8:29 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 13 2021, 9:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Apr 14 2021, 8:40 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 29 2021, 5:07 PM
ppelberg closed this task as Resolved.May 1 2021, 1:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits