Page MenuHomePhabricator
Create Task
Maniphest T279604

[Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
  • mwversion: Beta cluster
  • reqId: YG4tpQh2EwqJ5IFH4bUusAAAAAs
normalized_message
[YG4vbwh2EwqJ5IFH4bUwYQAAABI] /wiki/User_talk:RYasmeen_(WMF)/sandbox Error: Call to a member function equals() on boolean
exception.trace
/srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/HookUtils.php(221)
#0 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/PageHooks.php(122): MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::isFeatureEnabledForOutput(OutputPage, string)
#1 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\DiscussionTools\Hooks\PageHooks->onOutputPageBeforeHTML(OutputPage, string)
#2 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(2762): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-master/includes/OutputPage.php(2007): MediaWiki\HookContainer\HookRunner->onOutputPageBeforeHTML(OutputPage, string)
#4 /srv/mediawiki/php-master/includes/OutputPage.php(2019): OutputPage->addParserOutputText(ParserOutput, array)
#5 /srv/mediawiki/php-master/includes/page/Article.php(796): OutputPage->addParserOutput(ParserOutput, array)
#6 /srv/mediawiki/php-master/includes/page/Article.php(654): Article->doOutputFromParserCache(ParserOutput, OutputPage, array)
#7 /srv/mediawiki/php-master/includes/page/Article.php(561): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#8 /srv/mediawiki/php-master/includes/actions/ViewAction.php(74): Article->view()
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(531): ViewAction->show()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(315): MediaWiki->performAction(Article, Title)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(913): MediaWiki->performRequest()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(546): MediaWiki->main()
#13 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact
Notes

Details

Request ID
YG4tpQh2EwqJ5IFH4bUusAAAAAs
Request URL
https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:RYasmeen_(WMF)/sandbox
SubjectRepoBranchLines +/-
Fix check for your own talk page on subpagesmediawiki/extensions/DiscussionToolsREL1_36+2 -2
Fix check for your own talk page on subpagesmediawiki/extensions/DiscussionToolsmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 7 2021, 10:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2021, 10:21 PM
Ryasmeen renamed this task from Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster to [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster.Apr 7 2021, 10:35 PM
Krinkle subscribed.EditedApr 7 2021, 10:47 PM

Ran into this as well. Seems like trying to view any sub of a talk page on a wiki with DT installed serves this fatal error. Probably a very small bug, but makes these pages entirely unavailable – including for people not using/enabling DT. Worked yesterday I think?

https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Krinkle/sandbox
https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Foo/bar

gerritbot added a comment.Apr 7 2021, 11:22 PM

Change 677675 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix check for your own talk page on subpages

https://gerrit.wikimedia.org/r/677675

gerritbot added a project: Patch-For-Review.Apr 7 2021, 11:22 PM
matmarex claimed this task.Apr 7 2021, 11:22 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Yes, a silly mistake, thanks for debugging @Krinkle.

• ppelberg subscribed.Apr 7 2021, 11:24 PM
Zabe mentioned this in T279949: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean.Apr 12 2021, 8:13 PM
Daniuu subscribed.Apr 12 2021, 8:37 PM
Zabe subscribed.Apr 12 2021, 8:51 PM
matmarex merged a task: T279949: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean.Apr 12 2021, 9:08 PM
matmarex added a parent task: T278345: 1.37.0-wmf.1 deployment blockers.
matmarex added subscribers: Urbanecm, matmarex, Daimona and 5 others.
gerritbot added a comment.Apr 12 2021, 9:46 PM

Change 677675 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix check for your own talk page on subpages

https://gerrit.wikimedia.org/r/677675

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 12 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2021, 10:10 PM
matmarex added a project: Editing QA.Apr 12 2021, 10:18 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

This should not be a release blocker any more. I don't see the issue on any page on Beta.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 13 2021, 6:47 PM
In T279604#6992472, @matmarex wrote:

This should not be a release blocker any more. I don't see the issue on any page on Beta.

yes, fixed now. Checked on couple of sub-page's talk pages on Beta cluster. Thanks @matmarex for fixing this so promptly! :)

Ryasmeen edited projects, added Verified; removed Editing QA.Apr 13 2021, 6:47 PM
Urbanecm removed a parent task: T278345: 1.37.0-wmf.1 deployment blockers.Apr 13 2021, 8:56 PM
• ppelberg closed this task as Resolved.Apr 14 2021, 1:19 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 14 2021, 1:19 AM
gerritbot added a comment.Jun 12 2021, 8:14 PM

Change 699513 had a related patch set uploaded (by Paladox; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@REL1_36] Fix check for your own talk page on subpages

https://gerrit.wikimedia.org/r/699513

gerritbot added a project: Patch-For-Review.Jun 12 2021, 8:14 PM
gerritbot added a comment.Jun 12 2021, 10:17 PM

Change 699513 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_36] Fix check for your own talk page on subpages

https://gerrit.wikimedia.org/r/699513

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2021, 11:10 PM
Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 7 2022, 3:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL