Page MenuHomePhabricator
Create Task
Maniphest T279650

Move WikibaseRepo LanguageNameLookup to service container
Closed, ResolvedPublic
Actions

Description

This feels like a service that should be removed entirely, and replaced with MediaWiki’s LanguageNameUtils (which I assume didn’t exist at the time), but let’s move it to the service container first.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
repo: move LanguageNameLookup to service containermediawiki/extensions/Wikibasemaster+50 -10
Update WikibaseRepo::getLanguageNameLookup() callsmediawiki/extensions/WikibaseLexememaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 8 2021, 11:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2021, 11:36 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 8 2021, 11:40 AM
Lucas_Werkmeister_WMDE claimed this task.Apr 8 2021, 2:21 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T279673: Move WikibaseRepo EntityIdHtmlLinkFormatterFactory to service container.Apr 8 2021, 2:51 PM
gerritbot added a comment.Apr 8 2021, 3:01 PM

Change 677929 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: move LanguageNameLookup to service container

https://gerrit.wikimedia.org/r/677929

gerritbot added a project: Patch-For-Review.Apr 8 2021, 3:01 PM

Change 677930 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getLanguageNameLookup() calls

https://gerrit.wikimedia.org/r/677930

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 8 2021, 3:03 PM
gerritbot added a comment.Apr 12 2021, 2:37 PM

Change 677929 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: move LanguageNameLookup to service container

https://gerrit.wikimedia.org/r/677929

gerritbot added a comment.Apr 12 2021, 2:37 PM

Change 677930 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getLanguageNameLookup() calls

https://gerrit.wikimedia.org/r/677930

ItamarWMDE closed this task as Resolved.Apr 12 2021, 2:45 PM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 12 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2021, 3:10 PM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 15 2021, 4:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits