Page MenuHomePhabricator

Ensure that all of topic subscriptions code is behind the feature flag
Closed, ResolvedPublic

Description

All of topic subscriptions code must be behind the feature flag ($wgDiscussionTools_topicsubscription). It would be confusing if any interface elements appeared but were not functional. It could also cause scary-looking errors, because the code won't work until the related database tables have been created in production (T263817).

Test instructions

Browse around and make sure that no interface elements of topic subscriptions appear, including:

  • The subscribe/unsubscribe buttons on pages
  • Echo preferences
  • Notifications

Event Timeline

Change 677864 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Topic subscriptions: Don't generate events when feature is unavailable

https://gerrit.wikimedia.org/r/677864

Change 677927 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Disable topic subscriptions API when feature is unavailable

https://gerrit.wikimedia.org/r/677927

Change 678392 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Topic subscriptions: Don't register noitification type/group unless enabled

https://gerrit.wikimedia.org/r/678392

Change 677864 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Topic subscriptions: Don't generate events when feature is unavailable

https://gerrit.wikimedia.org/r/677864

Change 677927 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Disable topic subscriptions API when feature is unavailable

https://gerrit.wikimedia.org/r/677927

Change 678392 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Topic subscriptions: Don't register notification type/group unless enabled

https://gerrit.wikimedia.org/r/678392

ppelberg claimed this task.