Page MenuHomePhabricator
Create Task
Maniphest T279673

Move WikibaseRepo EntityIdHtmlLinkFormatterFactory to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T279650: Move WikibaseRepo LanguageNameLookup to service container.

Details

SubjectRepoBranchLines +/-
Update WikibaseRepo::getEntityIdHtmlLinkFormatterFactory to staticmediawiki/extensions/WikibaseLexememaster+2 -4
Update WikibaseRepo::getEntityIdHtmlLinkFormatterFactory to staticmediawiki/extensions/WikibaseQualityConstraintsmaster+12 -9
Move WikibaseRepo EntityIdHtmlLinkFormatterFactory to service containermediawiki/extensions/Wikibasemaster+98 -26
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 8 2021, 2:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2021, 2:51 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 8 2021, 3:00 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 12 2021, 2:46 PM
Lucas_Werkmeister_WMDE added a comment.Apr 12 2021, 3:34 PM

Note: this will probably be the last caller of WikibaseRepo::inFederatedPropertyMode() (it’s also used by PropertyDataTypeLookup, but that’s already being migrated in T279526), so that method can probably be removed here.

ItamarWMDE claimed this task.Apr 13 2021, 8:17 AM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
ItamarWMDE added a comment.EditedApr 13 2021, 9:30 AM
In T279673#6991611, @Lucas_Werkmeister_WMDE wrote:

Note: this will probably be the last caller of WikibaseRepo::inFederatedPropertyMode() (it’s also used by PropertyDataTypeLookup, but that’s already being migrated in T279526), so that method can probably be removed here.

It seems like inFederatedPropertyMode() is also called outside WikibaseRepo.php, so I will not include it in this change.

gerritbot added a comment.Apr 13 2021, 10:56 AM

Change 678816 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo EntityIdHtmlLinkFormatterFactory to service container

https://gerrit.wikimedia.org/r/678816

gerritbot added a project: Patch-For-Review.Apr 13 2021, 10:56 AM
gerritbot added a comment.Apr 13 2021, 11:06 AM

Change 678819 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityIdHtmlLinkFormatterFactory to static

https://gerrit.wikimedia.org/r/678819

gerritbot added a comment.Apr 13 2021, 11:20 AM

Change 678822 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityIdHtmlLinkFormatterFactory to static

https://gerrit.wikimedia.org/r/678822

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 13 2021, 11:22 AM
ItamarWMDE mentioned this in T280122: WikibaseRepo: Move EntityDiffVisualizerFactory to service container.Apr 14 2021, 10:58 AM
ItamarWMDE mentioned this in T280123: WikibaseRepo: Move ViewFactory to service container.Apr 14 2021, 11:01 AM
gerritbot added a comment.Apr 14 2021, 2:40 PM

Change 678816 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo EntityIdHtmlLinkFormatterFactory to service container

https://gerrit.wikimedia.org/r/678816

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 14 2021, 3:00 PM
gerritbot added a comment.Apr 14 2021, 4:15 PM

Change 678819 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityIdHtmlLinkFormatterFactory to static

https://gerrit.wikimedia.org/r/678819

gerritbot added a comment.Apr 14 2021, 4:39 PM

Change 678822 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityIdHtmlLinkFormatterFactory to static

https://gerrit.wikimedia.org/r/678822

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 14 2021, 4:41 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Maintenance_bot removed a project: Patch-For-Review.Apr 14 2021, 5:10 PM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 15 2021, 4:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL