The WikibaseRepo class has a getSiteLookup() method, a shortcut for getting the SiteLookup service from MediaWikiServices. It’s used in some other service wiring functions in WikibaseRepo, and those uses will be removed as we move the remaining services to the service wiring file (where we can use $services->getSiteLookup() instead). But it’s also called elsewhere, including in factory functions for API modules and special pages that could actually have a SiteLookup service properly injected. We should fix those uses, and either properly inject the SiteLookup or just call MediaWikiServices::getInstance()->getSiteLookup() directly, so that WikibaseRepo::getSiteLookup() can be removed once it’s no longer used by any other WikibaseRepo method.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 678233 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: inject SiteLookup as service where possible
Comment Actions
Change 678234 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: get SiteLookup from MediaWikiServices
Comment Actions
Change 678233 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: inject SiteLookup as service where possible
Comment Actions
Change 678234 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: get SiteLookup from MediaWikiServices