Page MenuHomePhabricator
Create Task
Maniphest T279682

Linter false positive: ref name containing pipe detected as bogus image option
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:
Inside a File: caption, create a ref tag with a name containing pipes, e.g. <ref name="foo|bar"> or <ref name=foo|bar>

See test cases:
https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=1016691750
https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=1016692017

Actual Results:
Linter shows a bogus image options error.

Expected Results:
Linter should not show a bogus image options error. It should ignore pipes and other text inside of ref names.

Details

SubjectRepoBranchLines +/-
composer: Lock Parsoid version to specific 0.13.0 releasemediawiki/coreREL1_36+1 -1
Bump wikimedia/parsoid to "release version" 0.13.0mediawiki/vendorREL1_36+436 -264
Bump wikimedia/parsoid to "release version" 0.13.0mediawiki/vendorREL1_36+436 -264
Bump wikimedia/parsoid to 0.14.0-a2mediawiki/vendormaster+98 -27
Handle optional spaces after table_attributes for table_row_tagmediawiki/services/parsoidmain+36 -4
[WIP] Handle optional spaces after table_attributesmediawiki/services/parsoidmaster+137 -81
Bump wikimedia/parsoid to 0.14.0-a1 for MW 1.37mediawiki/vendormaster+472 -265
Don't break on pipe in linkdescs if we're in an ext tagmediawiki/services/parsoidmaster+17 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jonesey95 created this task.Apr 8 2021, 3:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2021, 3:40 PM
Jonesey95 added a comment.Apr 8 2021, 3:43 PM

This is a subtask of T274382.

Aklapper added a parent task: T274382: Make File syntax processing match the specification and documentation.Apr 8 2021, 3:57 PM
Arlolra claimed this task.Apr 8 2021, 4:01 PM
Arlolra triaged this task as Medium priority.
Arlolra added a project: Parsoid.
Arlolra subscribed.

This is problem with Parsoid's tokenizer,

0-[peg]        | ---->   [{"type":"SelfclosingTagTk","name":"wikilink","attribs":[{"k":"href","v":["File:Meso2mil-English.JPG"],"srcOffsets":[2,2,2,27],"vsrc":"File:Meso2mil-English.JPG"},{"k":"mw:maybeContent","v":["thumb"],"srcOffsets":[28,28,28,33],"vsrc":"thumb"},{"k":"mw:maybeContent","v":["Beginning of image caption text.<ref name=\"foo"],"srcOffsets":[34,34,34,80],"vsrc":"Beginning of image caption text.<ref name=\"foo"},{"k":"mw:maybeContent","v":["bar\">Foo"],"srcOffsets":[81,81,81,89],"vsrc":"bar\">Foo"},{"k":"mw:maybeContent","v":["bar ref text",{"type":"EndTagTk","name":"ref","attribs":[],"dataAttribs":{"tsr":[102,108],"stx":"html"}}," Rest of text."],"srcOffsets":[90,90,90,122],"vsrc":"bar ref text</ref> Rest of text."}],"dataAttribs":{"tsr":[0,124],"src":"[[File:Meso2mil-English.JPG|thumb|Beginning of image caption text.<ref name=\"foo|bar\">Foo|bar ref text</ref> Rest of text.]]"}}]

https://en.wikipedia.org/api/rest_v1/page/html/User:Jonesey95%2Fsandbox/1016692017

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Apr 8 2021, 4:02 PM
Jonesey95 added a comment.Apr 8 2021, 4:09 PM

Possibly related: table markup inside an image caption causes similar false positives. See https://en.wikipedia.org/w/index.php?title=English_language&oldid=1016445842

I "fixed" this one by using {{!}} for the table markup pipes, but that should not be necessary.

gerritbot added a comment.Apr 8 2021, 5:03 PM

Change 677976 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Don't break on pipe in linkdescs if we're in an ext tag

https://gerrit.wikimedia.org/r/677976

gerritbot added a project: Patch-For-Review.Apr 8 2021, 5:03 PM
Jonesey95 updated the task description. (Show Details)Apr 8 2021, 5:16 PM
Arlolra added a comment.Apr 8 2021, 10:16 PM
In T279682#6984631, @Jonesey95 wrote:

Possibly related: table markup inside an image caption causes similar false positives

Also a tokenizing issue, but requires a different fix.

0-[peg]        | ---->   [{"type":"SelfclosingTagTk","name":"wikilink","attribs":[{"k":"href","v":["File:Test.jpg"],"srcOffsets":[2,2,2,15],"vsrc":"File:Test.jpg"},{"k":"mw:maybeContent","v":["thumb"],"srcOffsets":[16,16,16,21],"vsrc":"thumb"},{"k":"mw:maybeContent","v":["\n{"],"srcOffsets":[22,22,22,24],"vsrc":"\n{"},{"k":"mw:maybeContent","v":["\n"],"srcOffsets":[25,25,25,26],"vsrc":"\n"},{"k":"mw:maybeContent","v":["-\t \n"],"srcOffsets":[27,27,27,31],"vsrc":"-\t \n"},{"k":"mw:maybeContent","v":["\n"],"srcOffsets":[32,32,32,33],"vsrc":"\n"},{"k":"mw:maybeContent","v":["}\n"],"srcOffsets":[34,34,34,36],"vsrc":"}\n"}],"dataAttribs":{"tsr":[0,38],"src":"[[File:Test.jpg|thumb|\n{|\n|-\t \n|\n|}\n]]"}}]

https://en.wikipedia.org/api/rest_v1/page/html/English_language/1016445842#Pluricentric_English

gerritbot added a comment.Apr 8 2021, 10:58 PM

Change 678111 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Handle optional spaces after table_attributes

https://gerrit.wikimedia.org/r/678111

gerritbot added a comment.Apr 14 2021, 6:02 PM

Change 677976 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Don't break on pipe in linkdescs if we're in an ext tag

https://gerrit.wikimedia.org/r/677976

gerritbot added a comment.Apr 26 2021, 5:08 PM

Change 682690 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.14.0-a1

https://gerrit.wikimedia.org/r/682690

gerritbot added a comment.Apr 26 2021, 9:58 PM

Change 682690 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a1 for MW 1.37

https://gerrit.wikimedia.org/r/682690

gerritbot added a comment.Apr 27 2021, 8:39 PM

Change 683072 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@main] Handle optional spaces after table_attributes for table_row_tag

https://gerrit.wikimedia.org/r/683072

gerritbot added a comment.Apr 27 2021, 8:40 PM

Change 678111 abandoned by Arlolra:

[mediawiki/services/parsoid@master] [WIP] Handle optional spaces after table_attributes

Reason:

In favour of https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/ /683072/ against main

https://gerrit.wikimedia.org/r/678111

gerritbot added a comment.Apr 29 2021, 12:03 AM

Change 683072 merged by jenkins-bot:

[mediawiki/services/parsoid@main] Handle optional spaces after table_attributes for table_row_tag

https://gerrit.wikimedia.org/r/683072

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 12:10 AM
Arlolra closed this task as Resolved.Apr 29 2021, 2:44 PM
gerritbot added a comment.May 3 2021, 8:41 PM

Change 684500 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a2

https://gerrit.wikimedia.org/r/684500

gerritbot added a project: Patch-For-Review.May 3 2021, 8:41 PM
gerritbot added a comment.May 3 2021, 9:48 PM

Change 684500 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a2

https://gerrit.wikimedia.org/r/684500

gerritbot added a comment.May 24 2021, 10:43 PM

Change 693970 had a related patch set uploaded (by C. Scott Ananian; author: Jforrester):

[mediawiki/core@REL1_36] composer: Lock Parsoid version to specific 0.13.0 release

https://gerrit.wikimedia.org/r/693970

gerritbot added a comment.May 24 2021, 10:48 PM

Change 693972 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

https://gerrit.wikimedia.org/r/693972

gerritbot added a comment.May 24 2021, 10:51 PM

Change 693971 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

https://gerrit.wikimedia.org/r/693971

gerritbot added a comment.May 24 2021, 10:51 PM

Change 693972 abandoned by C. Scott Ananian:

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

Reason:

in favor of I2bfdd568ba24489830fb0d6799524058b3b6d65f

https://gerrit.wikimedia.org/r/693972

gerritbot added a comment.May 24 2021, 11:49 PM

Change 693971 merged by Jforrester:

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

https://gerrit.wikimedia.org/r/693971

gerritbot added a comment.May 25 2021, 12:01 AM

Change 693970 merged by jenkins-bot:

[mediawiki/core@REL1_36] composer: Lock Parsoid version to specific 0.13.0 release

https://gerrit.wikimedia.org/r/693970

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL