Page MenuHomePhabricator
Create Task
Maniphest T279740

[enhancement] Diff should omit headers on sequential changes to the same collection field
Closed, ResolvedPublic
Actions

Description

  • Edit a tool and add a 3-4 ui languages
  • View the diff of that revision to the prior revision
  • Expect one "Available UI languages" header with multiple values
  • See one set of headers for each language added

Details

SubjectRepoBranchLines +/-
ui: Refactor RevisionsDiff.vue and add header deduplicationwikimedia/toolhubmain+167 -106
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Apr 8 2021, 10:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2021, 10:45 PM
bd808 claimed this task.Apr 13 2021, 12:16 AM
bd808 moved this task from Backlog to In Progress on the Toolhub board.
bd808 added a project: Developer-Advocacy (Apr-Jun 2021).

I have something working for this in my local dev tree. I just need to untangle it from a pile of other refactorings and fixes I made along the way.

Restricted Application added a project: User-bd808. · View Herald TranscriptApr 13 2021, 12:16 AM
gerritbot added a comment.Apr 13 2021, 4:08 AM

Change 678706 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] ui: Refactor RevisionsDiff.vue and add header deduplication

https://gerrit.wikimedia.org/r/678706

gerritbot added a project: Patch-For-Review.Apr 13 2021, 4:08 AM
gerritbot added a comment.Apr 13 2021, 11:47 PM

Change 678706 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Refactor RevisionsDiff.vue and add header deduplication

https://gerrit.wikimedia.org/r/678706

jenkins-bot mentioned this in rWTHU9bf0379d814f: ui: Refactor RevisionsDiff.vue and add header deduplication.Apr 13 2021, 11:48 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 14 2021, 12:10 AM
bd808 closed this task as Resolved.Apr 14 2021, 6:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL