Page MenuHomePhabricator

[accepted revision] is white in FlaggedRevs diffs
Closed, ResolvedPublicBUG REPORT

Description

[accepted revision] used to have a pale green color in diffs, but now it’s white (has no background color, to be exact), because it lost its flaggdrevs-color-1 class with the deployment of MW-1.36-notes (1.36.0-wmf.38; 2021-04-06). It was already hard to distinguish “accepted” and “not accepted” labels at a glance, but it’s now even harder. Please restore the background color.

BeforeAfter
Screenshot
HTML(estimation) <table class='fr-diff-ratings'><tr><td style='text-align: center; width: 50%;'><span class='flaggedrevs-color-0'>[nem ellenőrzött változat]</span></td><td style='text-align: center; width: 50%;'><span class='flaggedrevs-color-1'>[ellenőrzött változat]</span></td></tr></table><table class='fr-diff-ratings'><tr><td style='text-align: center; width: 50%;'><span class='flaggedrevs-color-0'>[nem ellenőrzött változat]</span></td><td style='text-align: center; width: 50%;'><span class=''>[ellenőrzött változat]</span></td></tr></table>

Event Timeline

This issue also affects ?action=history and user contribs, where <li> elements used to have a prominent blue background (on plwiki and plwiktionary).

Ladsgroup added a subscriber: Ladsgroup.

I'll try to see what can be done to fix it.

This bug is present also after I accept the revision using the JavaScript interface using the button highlighted below. I don’t know if they use the same code path, but if they don’t, JS should be accounted for as well.

Change 678296 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/FlaggedRevs@master] Don't do strict equal condition check

https://gerrit.wikimedia.org/r/678296

Found the problem. This fixes it. If gets merged by Monday, I'll backport it. Sorry for the inconvenience. This codebase is beyond rotten. Any change on it is bound to break something it seems but it's necessary to make the code slightly more maintainable.

Change 678296 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Don't do strict equal condition check

https://gerrit.wikimedia.org/r/678296

Change 678347 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/FlaggedRevs@wmf/1.36.0-wmf.38] Don't do strict equal condition check

https://gerrit.wikimedia.org/r/678347

Change 678347 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.36.0-wmf.38] Don't do strict equal condition check

https://gerrit.wikimedia.org/r/678347

Mentioned in SAL (#wikimedia-operations) [2021-04-12T11:26:45Z] <ladsgroup@deploy1002> Synchronized php-1.36.0-wmf.38/extensions/FlaggedRevs/frontend/FlaggedRevsXML.php: Backport: [[gerrit:678347|Don't do strict equal condition check (T279750)]] (duration: 00m 57s)