Go to this diff with Google Chrome.
What I expect: Approved Revision vs. Pending Revision diff.
What happens is that the former revision is flagged in a very strange way.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
Happens again. It seems not to be a problem with a specific diff, but rather with PCR as a whole.
Comment Actions
Hi @Firestar464, thanks for taking the time to report this! Unfortunately this Wikimedia Phabricator task lacks some information.
If you have time and can still reproduce the situation: Please add a more complete description to this task. That should be
- a clear and complete list of exact steps to reproduce the situation, step by step, so that nobody needs to guess or interpret how you performed each step,
- what happens after performing these steps to reproduce,
- what you expected to happen instead.
We currently don't know what's "strange". Or what you expect where exactly. (Or where all those colorful items come from which I don't see here.) Thanks!
Comment Actions
Sorry for being a noob, the "strange" part is that it displays "revreview-hist-quality" rather than "approved," "quality," or "pending." Also, the colorful buttons are from WP:Redwarn, an anti-vandalism tool.
Comment Actions
Ah, thanks a lot for the clarification. I first checked https://translatewiki.net/wiki/MediaWiki:Revreview-hist-quality/en which looks fine. Then I realized the ⧼⧽ brackets. Looking at recent code changes, this looks like a regression from 04ffb5f56f2331138f2463584aacbb702e8d243e. Giving a heads-up to @Ladsgroup.
Comment Actions
Yeah. I was worried this might happen. Basically we dropped the quality tier but there are edits that are marked as quality and the system doesn't know what to do with them. My suggestion would be to mark all of them as checked in the database. That's not hard to do but I rather not do it in a weekend (where our capacity is reduced and if things go wrong, can't ask for help)
Comment Actions
Yes. I'm aware of that but I rather do it at end of the all the work to reduce the risk of issues.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-05-15T12:33:21Z] <Amir1> set fr_quality to 0 for all revisions on several wikis (T279761)
Comment Actions
@Aklapper , @Ladsgroup , has this been fixed on enwiki? I can't see it anymore when going through the diffs at https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox/T279276&action=history
Comment Actions
I cleaned enwiki a while ago but I haven't got to cleaning other wikis yet. I'll be on it.
Comment Actions
@Firestar464: Do you plan to work on fixing this task, as you increased the priority of this task?
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2021-06-16T08:24:18Z] <Amir1> running "update flaggedrevs set fr_quality = 0 where fr_quality != 0;" on all wikis where flagged revs is enabled (T279761)