Page MenuHomePhabricator
Create Task
Maniphest T279779

Evaluate PHP8 compatibility of FOC
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In order to upgrade to PHP 8, we need to figure out whether the Fundraising Operation Center is compatible with PHP 8 and/or what needs to be done to make it compatible.

Details

  • Locally install phpstan to analyze code. Probably phpstan will report more issues that are not related to PHP8 incompatibility.
  • Use updated PHP8 docker image.
  • Locally user test application (donation list, export, a/b test analysis).
  • Document possible phpstan reports that are related to PHP8 and broken features including log files.

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolvedgabriel-wmdeT270715 Update to PHP 8.0
 ResolvedNoneT279779 Evaluate PHP8 compatibility of FOC
 DeclinedNoneT282651 Update XDebug instructions for XDebug 3 usage in PHPStorm

Event Timeline

kai.nissen created this task.Apr 9 2021, 12:50 PM
kai.nissen updated the task description. (Show Details)Apr 9 2021, 12:58 PM
kai.nissen set the point value for this task to 5.
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.Apr 9 2021, 2:36 PM
kai.nissen added a project: WMDE-FUN-Sprint-2021-04-12.Apr 12 2021, 10:57 AM
gabriel-wmde mentioned this in T279777: Change docker file to use PHP 8.Apr 14 2021, 8:32 AM
kai.nissen removed a project: WMDE-FUN-Sprint-2021-04-12.Apr 14 2021, 9:14 AM
kai.nissen added a project: WMDE-FUN-Sprint-2021-04-26.Apr 26 2021, 10:38 AM
kai.nissen moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Apr 26 2021, 10:46 AM
gabriel-wmde moved this task from Todo to Doing on the WMDE-FUN-Sprint-2021-04-26 board.Apr 27 2021, 4:20 PM
gabriel-wmde moved this task from Backlog to Sprint Ready on the WMDE-Fundraising-CFR board.May 4 2021, 4:05 PM
gabriel-wmde moved this task from Doing to Review on the WMDE-FUN-Sprint-2021-04-26 board.May 6 2021, 3:29 PM
gabriel-wmde moved this task from Review to Deploy on the WMDE-FUN-Sprint-2021-04-26 board.

I have used the compatibility check tool and ran an analysis and report on the desktop campaign No. 20 from 2020 without problems.

gabriel-wmde moved this task from Deploy to Review on the WMDE-FUN-Sprint-2021-04-26 board.May 6 2021, 3:36 PM

The only change needed was an Update to XDebug: https://github.com/wmde/fundraising-backend/pull/478

gabriel-wmde added a comment.May 10 2021, 8:25 AM

While running the unit tests, I found out that the error handling of Silex throws deprecation errors in PHPUnit. I've created a pull request to remove Silex: https://github.com/wmde/fundraising-backend/pull/480

kai.nissen changed the point value for this task from 5 to 1.May 10 2021, 10:16 AM
kai.nissen added a project: WMDE-Fun-Sprint-2021-05-10.May 10 2021, 10:25 AM
kai.nissen moved this task from Todo to Review on the WMDE-Fun-Sprint-2021-05-10 board.
kai.nissen moved this task from Review to Done on the WMDE-Fun-Sprint-2021-05-10 board.May 25 2021, 10:25 AM
kai.nissen closed this task as Resolved.Jun 7 2021, 8:38 AM
kai.nissen closed subtask T282651: Update XDebug instructions for XDebug 3 usage in PHPStorm as Declined.Jan 30 2024, 11:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL