Maniphest T279795

Edit button always shown as "CANCEL" when interface language is a language that uses LanguageConverter (e.g. `zh`, `yue`, `gan`)
Closed, ResolvedPublic
Actions

Assigned To

Universal_Omega

Authored By

	Lakejason0
	Apr 9 2021, 4:21 PM

Tags

Referenced Files

	F34314888: image.png
	Apr 9 2021, 4:21 PM

Subscribers

Description

image.png (928×1 px, 141 KB)

When site language or interface language is set as a language that uses LanguageConverter (which adds a variant menu in the dropdown), for example zh, the Edit Button is always shown as "CANCEL".
Example: https://meta.miraheze.org/wiki/Miraheze/zh?useskin=cosmos&uselang=yue, https://meta.miraheze.org/wiki/Miraheze/zh?useskin=cosmos&uselang=zh and https://meta.miraheze.org/wiki/Miraheze/zh?useskin=cosmos&uselang=gan.

Event Timeline

Lakejason0 created this task.Apr 9 2021, 4:21 PM

Restricted Application added a project: User-RhinosF1. · View Herald TranscriptApr 9 2021, 4:21 PM

Restricted Application added subscribers: RhinosF1, Reception123. · View Herald Transcript

Lakejason0 updated the task description. (Show Details)Apr 9 2021, 4:21 PM

Universal_Omega triaged this task as High priority.Apr 9 2021, 5:02 PM

Universal_Omega claimed this task.Apr 9 2021, 5:24 PM

So upon looking into this, the issue seems to come from https://github.com/wikimedia/mediawiki-skins-Cosmos/blob/5d41048/includes/CosmosTemplate.php#L1026 meaning there is no check for the action that is producing that in the above switch leading to that default statement, in turn leading to outputting https://github.com/wikimedia/mediawiki-skins-Cosmos/blob/5d41048/includes/CosmosTemplate.php#L1075-L1087

Universal_Omega closed this task as Resolved.Oct 23 2021, 3:42 AM