Page MenuHomePhabricator

Replace Title parameters in service classes
Open, HighPublic

Description

Service objects accessible from MediaWikiServices are used by many different parts of the code. Converting their public interfaces away from using Title allows other code that uses these services to be converted away from using Title.

Number of Title parameters found:

Event Timeline

daniel updated the task description. (Show Details)
daniel updated the task description. (Show Details)
daniel triaged this task as High priority.Apr 9 2021, 5:34 PM

Change 678429 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] HtmlCacheUpdater: replace Title in method signatures.

https://gerrit.wikimedia.org/r/678429

Change 678430 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] SpecialPageFactory: replace Title in method signatures

https://gerrit.wikimedia.org/r/678430

Change 678430 merged by jenkins-bot:

[mediawiki/core@master] SpecialPageFactory: replace Title in method signatures

https://gerrit.wikimedia.org/r/678430

Change 678429 merged by jenkins-bot:

[mediawiki/core@master] HtmlCacheUpdater: replace Title in method signatures.

https://gerrit.wikimedia.org/r/678429

daniel updated the task description. (Show Details)

Change 682177 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Remove deprecated methods from RevisionStore

https://gerrit.wikimedia.org/r/682177

Change 682246 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] PageProps: use PageIdentity instead of Title

https://gerrit.wikimedia.org/r/682246

Change 682246 merged by jenkins-bot:

[mediawiki/core@master] PageProps: use PageIdentity instead of Title

https://gerrit.wikimedia.org/r/682246

Change 682714 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714

Change 682714 merged by jenkins-bot:

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714

Change 682714 merged by jenkins-bot:

[mediawiki/core@master] Revert "PageProps: use PageIdentity instead of Title"

https://gerrit.wikimedia.org/r/682714

This change has since been re-applied, although it was not tracked here:

Change by Daniel Kinzler, merged:

[mediawiki/core] Re-apply "PageProps: use PageIdentity instead of Title"

It should no longer fail now with Title::assertProperPage ignoring fragments.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/682825

This however led to a second issue, which is that PageProps would not work with invalid titles anymore (e.g. Special pages). These were previously implicitly tolerated as Title->getArticleID() returns 0 for special pages. But, the new code in the above patch uses the stricter getId which throws for invalid titles.

This problem was found in T283170, and since been fixed in another commit that was not tracked here:

Change by Ppchelko, merged:

[mediawiki/core] PageProps: be prepared that PageIdentity is not proper title

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/692968/

Change 682177 abandoned by Daniel Kinzler:

[mediawiki/core@master] Remove deprecated methods from RevisionStore

Reason:

obsolete

https://gerrit.wikimedia.org/r/682177