Page MenuHomePhabricator
Create Task
Maniphest T279803

PHP Notice: Undefined index:
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.38

message
PHP Notice: Undefined index:

Impact

Stack Trace

from /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSections.php(309)
#0 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSections.php(309): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSections.php(325): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections->getDSR(array, DOMElement, boolean)
#2 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSections.php(533): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections->getDSR(array, DOMElement, boolean)
#3 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/WrapSections.php(583): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections->resolveTplExtSectionConflicts(array)
#4 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(158): Wikimedia\Parsoid\Wt2Html\PP\Processors\WrapSections->run(Wikimedia\Parsoid\Config\Env, DOMElement, array, boolean)
#5 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(853): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->Wikimedia\Parsoid\Wt2Html\{closure}(DOMElement, array, boolean)
#6 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(903): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(DOMElement)
#7 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(920): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->process(DOMElement)
#8 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(178): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#9 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(310): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#10 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(106): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#11 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Parsoid.php(162): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#12 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/src/Parsoid.php(194): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#13 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(589): Wikimedia\Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#14 /srv/mediawiki/php-1.36.0-wmf.38/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(88): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(MWParsoid\Config\PageConfig, array)
#15 /srv/mediawiki/php-1.36.0-wmf.38/includes/Rest/Router.php(395): MWParsoid\Rest\Handler\PageHandler->execute()
#16 /srv/mediawiki/php-1.36.0-wmf.38/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#17 /srv/mediawiki/php-1.36.0-wmf.38/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#18 /srv/mediawiki/php-1.36.0-wmf.38/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#19 /srv/mediawiki/php-1.36.0-wmf.38/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#20 /srv/mediawiki/w/rest.php(3): require(string)
#21 {main}

Notes

Details

Request URL
https://pl.wikipedia.org/w/rest.php/pl.wikipedia.org/v3/page/pagebundle/Wikipedia%3AKawiarenka%2FStoliki/59627175
SubjectRepoBranchLines +/-
composer: Lock Parsoid version to specific 0.13.0 releasemediawiki/coreREL1_36+1 -1
Bump wikimedia/parsoid to "release version" 0.13.0mediawiki/vendorREL1_36+436 -264
Bump wikimedia/parsoid to "release version" 0.13.0mediawiki/vendorREL1_36+436 -264
Bump wikimedia/parsoid to 0.14.0-a1 for MW 1.37mediawiki/vendormaster+472 -265
Fixing asserting an about idmediawiki/services/parsoidmaster+4 -1
Customize query in gerrit

Event Timeline

ssastry triaged this task as Medium priority.Apr 9 2021, 7:09 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2021, 7:09 PM
ssastry updated the task description. (Show Details)Apr 9 2021, 7:09 PM
gerritbot added a comment.Apr 14 2021, 6:02 PM

Change 679409 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Fixing asserting an about id

https://gerrit.wikimedia.org/r/679409

gerritbot added a project: Patch-For-Review.Apr 14 2021, 6:02 PM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Apr 14 2021, 6:04 PM
Arlolra subscribed.

The patch doesn't fix the bug from an incorrect assumption, it just changes this from a PHP Notice to an assertion failure, as was desired.

Wasn't reproducible locally with,

php bin/parse.php --domain pl.wikipedia.org --pageName "Wikipedia:Kawiarenka/Stoliki" --oldid 59627175 < /dev/null
gerritbot added a comment.Apr 14 2021, 6:46 PM

Change 679409 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fixing asserting an about id

https://gerrit.wikimedia.org/r/679409

Arlolra closed this task as Resolved.Apr 14 2021, 6:55 PM
Arlolra claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Apr 14 2021, 7:10 PM
gerritbot added a comment.Apr 26 2021, 5:08 PM

Change 682690 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.14.0-a1

https://gerrit.wikimedia.org/r/682690

gerritbot added a project: Patch-For-Review.Apr 26 2021, 5:08 PM
gerritbot added a comment.Apr 26 2021, 9:58 PM

Change 682690 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a1 for MW 1.37

https://gerrit.wikimedia.org/r/682690

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 10:12 PM
gerritbot added a comment.May 24 2021, 10:43 PM

Change 693970 had a related patch set uploaded (by C. Scott Ananian; author: Jforrester):

[mediawiki/core@REL1_36] composer: Lock Parsoid version to specific 0.13.0 release

https://gerrit.wikimedia.org/r/693970

gerritbot added a project: Patch-For-Review.May 24 2021, 10:43 PM
gerritbot added a comment.May 24 2021, 10:48 PM

Change 693972 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

https://gerrit.wikimedia.org/r/693972

gerritbot added a comment.May 24 2021, 10:51 PM

Change 693971 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

https://gerrit.wikimedia.org/r/693971

gerritbot added a comment.May 24 2021, 10:51 PM

Change 693972 abandoned by C. Scott Ananian:

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

Reason:

in favor of I2bfdd568ba24489830fb0d6799524058b3b6d65f

https://gerrit.wikimedia.org/r/693972

gerritbot added a comment.May 24 2021, 11:49 PM

Change 693971 merged by Jforrester:

[mediawiki/vendor@REL1_36] Bump wikimedia/parsoid to "release version" 0.13.0

https://gerrit.wikimedia.org/r/693971

gerritbot added a comment.May 25 2021, 12:01 AM

Change 693970 merged by jenkins-bot:

[mediawiki/core@REL1_36] composer: Lock Parsoid version to specific 0.13.0 release

https://gerrit.wikimedia.org/r/693970

Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 7 2022, 3:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL