Page MenuHomePhabricator

Improve Sonar job for analytics-refinery-source
Open, LowPublic

Description

There are some issues with the Sonar job in this repo,

  • Test coverage is not wired up
    • Zero coverage errors cause any patch touching .java files to fail checks.
    • We chould ignore code coverage with sonar.coverage.exclusions (?)
    • Or better, set up the job to actually run tests and measure coverage.
  • Scala code is not detected nor linted.
    • It seems to be supported by Sonar.
    • I can't see the project config, but if sonar.language is specified I think it should be removed, to enable multi-language detection.

Event Timeline

fdans moved this task from Incoming to Smart Tools for Better Data on the Analytics board.
fdans subscribed.

@awight do you feel like taking this one?

@awight do you feel like taking this one?

I'd be honored. It's probably easiest to add me as a GitHub project member (user adamwight) or whatever else configures adminship in Sonar, if that's acceptable. Otherwise, we could work together to e.g. get me the current Sonar config and I can work in an isolated sandbox project.

We could run coverage either in Jenkins or Sonar, but I guess the first step is to disable Sonar coverage, and then we can discuss re-enabling if desirable.

@awight You should not actually need any access to SonarCloud. The approach we're taking is keeping most of the configuration in the project repository. I'll try to add some more details later on.