Page MenuHomePhabricator

TemplateData editor shifts editnotices and textbox down, resulting in misclicks
Closed, ResolvedPublic

Description

Seeing that TemplateData might get some work from Wikimedia DE team, would like to log the following issue:

Currently, TemplateData inserts itself into a template editing window after the page load. This results in a generally jarring experience: you are opening a page, then something moves the whole page down after a second or two. More importantly, this can result in misclicks when you are clicking either into textbox or some editnotice and TemplateData editor suddenly inserts itself at the place of your click. (Entirely anecdotally, this happened to me at least a dozen times.)

This can be mitigated in two ways:

  1. Insert TemplateData editor after the edit notices (easy path).
  2. Insert TemplateData editor (and its various notices) in the actual extension code, showing the disabled interface to users on load with .client-js class and then initialising all the events directly on it.

I would prefer the second solution implemented someday.

Event Timeline

This is a pain point for me not just with the content block itself but also the warning that TemplateData exists on the /doc page (which I guess is even the worse problem for me).

thiemowmde added subscribers: TheDJ, Tacsipacsi, Dvorapa.

I created a short screencast that demonstrates the problem: when the page seems to have loaded, I try to click within the text box to write something at the beginning of the template, but suddenly the bold button is below my cursor instead of the text box. (Even worse, the sample text gets inserted with JavaScript, and thus Ctrl+Z doesn’t revert this insertion – at least not in Firefox.)

Change 785164 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateData@master] Add placeholder to avoid wikitext editor jumping down

https://gerrit.wikimedia.org/r/785164

Change 785164 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Add placeholder to avoid wikitext editor jumping down

https://gerrit.wikimedia.org/r/785164

This is a pain point for me not just with the content block itself but also the warning that TemplateData exists on the /doc page (which I guess is even the worse problem for me).

(Just a note that this part wasn’t fixed, and this warning still pushes the page down a bit.)