Page MenuHomePhabricator
Create Task
Maniphest T279932

Flaky Wikidata Bridge Brower Test "init indicates loading while app gathers its data"
Closed, ResolvedPublic
Actions

Description

Test seen failing on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/677235

Specifically this php 7.3 job: https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php73-selenium-docker/2741/console

Complete console log archived for posterity: https://phabricator.wikimedia.org/P15277

Related Objects

Event Timeline

Tarrow created this task.Apr 12 2021, 2:47 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptApr 12 2021, 2:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tarrow updated the task description. (Show Details)Apr 12 2021, 2:48 PM

Related to T277205

Addshore moved this task from Inbox to Investigate & Discuss on the [DEPRECATED] wdwb-tech board.Apr 12 2021, 6:21 PM
Addshore subscribed.

So looking at the log it appears that 2 tests fail with an ✖.
Both while waiting for some element to display.

15:10:55 [chrome 73.0.3683.75 Linux #0-4] Spec: /workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/errorHandling.js
15:10:55 [chrome 73.0.3683.75 Linux #0-4] Running: chrome (v73.0.3683.75) on Linux
15:10:55 [chrome 73.0.3683.75 Linux #0-4] Session ID: 391022688012a55f2a298fbcd3889dfd
15:10:55 [chrome 73.0.3683.75 Linux #0-4]
15:10:55 [chrome 73.0.3683.75 Linux #0-4] App
15:10:55 [chrome 73.0.3683.75 Linux #0-4]    ✓ shows ErrorUnknown when launching bridge for a non-existent entity
15:10:55 [chrome 73.0.3683.75 Linux #0-4]    ✓ can be relaunched from ErrorUnknown
15:10:55 [chrome 73.0.3683.75 Linux #0-4]    ✓ can retry saving bridge from ErrorSaving
15:10:55 [chrome 73.0.3683.75 Linux #0-4]    ✓ can go back from a save error both on desktop and mobile
15:10:55 [chrome 73.0.3683.75 Linux #0-4]
15:10:55 [chrome 73.0.3683.75 Linux #0-4]     when assertuser fails
15:10:55 [chrome 73.0.3683.75 Linux #0-4]        ? can retry saving without assertuser
15:10:55 [chrome 73.0.3683.75 Linux #0-4]        ✖ "before each" hook
15:10:55 [chrome 73.0.3683.75 Linux #0-4]
15:10:55 [chrome 73.0.3683.75 Linux #0-4]     when there is an edit conflict
15:10:55 [chrome 73.0.3683.75 Linux #0-4]        ✓ reloads on reload button click
15:10:55 [chrome 73.0.3683.75 Linux #0-4]        ✓ reloads on close button click
15:10:55 [chrome 73.0.3683.75 Linux #0-4]
15:10:55 [chrome 73.0.3683.75 Linux #0-4] 6 passing (38s)
15:10:55 [chrome 73.0.3683.75 Linux #0-4] 1 failing
15:10:55 [chrome 73.0.3683.75 Linux #0-4]
15:10:55 [chrome 73.0.3683.75 Linux #0-4] 1) when assertuser fails "before each" hook
15:10:55 [chrome 73.0.3683.75 Linux #0-4] element (".oo-ui-dialog #data-bridge-app .wb-db-bridge") still not displayed after 5000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-4] Error: element (".oo-ui-dialog #data-bridge-app .wb-db-bridge") still not displayed after 5000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-4]     at Context.beforeEach (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/errorHandling.js:237:26)
15:10:55 ------------------------------------------------------------------
15:10:55 [chrome 73.0.3683.75 Linux #0-5] Spec: /workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js
15:10:55 [chrome 73.0.3683.75 Linux #0-5] Running: chrome (v73.0.3683.75) on Linux
15:10:55 [chrome 73.0.3683.75 Linux #0-5] Session ID: a85802a5fcb68b36e06623f8ec18aabf
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5] init
15:10:55 [chrome 73.0.3683.75 Linux #0-5]    ✓ opens app in OOUI dialog
15:10:55 [chrome 73.0.3683.75 Linux #0-5]    ✖ indicates loading while app gathers its data
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5]     once app is launched
15:10:55 [chrome 73.0.3683.75 Linux #0-5]        ✓ shows the current targetValue
15:10:55 [chrome 73.0.3683.75 Linux #0-5]        ✓ shows the current targetReference
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5]         target property label
15:10:55 [chrome 73.0.3683.75 Linux #0-5]            ✓ uses the label from the page content language
15:10:55 [chrome 73.0.3683.75 Linux #0-5]            ✓ uses the label from a non-English fallback language
15:10:55 [chrome 73.0.3683.75 Linux #0-5]            ✓ uses the label from the English fallback language
15:10:55 [chrome 73.0.3683.75 Linux #0-5]            ✓ uses the property ID if no label in fallback chain found
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5]     warning for anonymous edits
15:10:55 [chrome 73.0.3683.75 Linux #0-5]        ✓ is not shown when logged in
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5]         when anonymous
15:10:55 [chrome 73.0.3683.75 Linux #0-5]            ✓ is shown and can be dismissed
15:10:55 [chrome 73.0.3683.75 Linux #0-5]            ✓ is shown and leads to login page
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5] 10 passing (45.8s)
15:10:55 [chrome 73.0.3683.75 Linux #0-5] 1 failing
15:10:55 [chrome 73.0.3683.75 Linux #0-5]
15:10:55 [chrome 73.0.3683.75 Linux #0-5] 1) init indicates loading while app gathers its data
15:10:55 [chrome 73.0.3683.75 Linux #0-5] waitUntil condition timed out after 10000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-5] Error: waitUntil condition timed out after 10000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-5]     at Context.it (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js:68:11)

Specifically these assertions waiting for:

15:10:55 [chrome 73.0.3683.75 Linux #0-4] 1) when assertuser fails "before each" hook
15:10:55 [chrome 73.0.3683.75 Linux #0-4] element (".oo-ui-dialog #data-bridge-app .wb-db-bridge") still not displayed after 5000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-4] Error: element (".oo-ui-dialog #data-bridge-app .wb-db-bridge") still not displayed after 5000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-4]     at Context.beforeEach (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/errorHandling.js:237:26)
&
15:10:55 [chrome 73.0.3683.75 Linux #0-5] 1) init indicates loading while app gathers its data
15:10:55 [chrome 73.0.3683.75 Linux #0-5] waitUntil condition timed out after 10000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-5] Error: waitUntil condition timed out after 10000ms
15:10:55 [chrome 73.0.3683.75 Linux #0-5]     at Context.it (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js:68:11)

This is as far as I got before realize that this is on REL1_35 that doesn't have the extended timeouts for tests that were recent added in

I believe this would mostly be https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/670428 that was done as part of T276932 but there might have been other such increases, particularly for bridge tests that were merged since REL1_35 was cut (probably worth a quick grp through the commit log).

Also per the latest maint reloaded workshop, this might constitute a "small task".
Shall I leave it to you @Tarrow ?

Addshore added a comment.Apr 12 2021, 7:06 PM

Also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/673545 ?

Addshore renamed this task from Flaky Wikidata Bridge Brower Test "init indicates loading while app gathers its data" to Flaky Wikidata Bridge Brower Test "init indicates loading while app gathers its data" on REL1_35.Apr 19 2021, 9:24 AM
Jakob_WMDE mentioned this in T281122: Wikibase selenium tests timeout, seemingly due to "memory compaction" events on CI VMs.Apr 26 2021, 11:53 AM
Jakob_WMDE subscribed.Apr 26 2021, 11:59 AM

Looks like it's indeed not limited to REL1_35. The also seem to still be flaky on master, see e.g. T281122.

Addshore renamed this task from Flaky Wikidata Bridge Brower Test "init indicates loading while app gathers its data" on REL1_35 to Flaky Wikidata Bridge Brower Test "init indicates loading while app gathers its data".Sep 9 2021, 8:59 AM
Addshore closed this task as Resolved.
Addshore claimed this task.

I'm going to mark this as resolved, as we did lots of work on making the bridge tests fail less (increasing timeouts etc)

Restricted Application added a project: User-Addshore. · View Herald TranscriptSep 9 2021, 9:00 AM
Addshore mentioned this in T265596: Investigate and possibly improve stability of browser tests.Sep 14 2021, 8:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL