Page MenuHomePhabricator

MediaWiki.NamingConventions.ValidGlobalName stops validation after php reserved global
Closed, ResolvedPublic

Description

In case of

global $wrongGlobal, $_GET, $wgRightGlobal, $anotherWrongGlobal;

The $anotherWrongGlobal is not detected by MediaWiki.NamingConventions.ValidGlobalName
Detection of $wrongGlobal is correct.

Event Timeline

Change 681372 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/tools/codesniffer@master] ValidGlobalNameSniff: don't return on first valid name

https://gerrit.wikimedia.org/r/681372

Change 681372 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] ValidGlobalNameSniff: don't return on first valid name

https://gerrit.wikimedia.org/r/681372

Umherirrender assigned this task to DannyS712.
Umherirrender removed a project: Patch-For-Review.