Maniphest T280000

Plugin detect links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SBisson
	Apr 13 2021, 10:24 AM

Project Tags

Referenced Files

None

Subscribers

Description

Context

As a Wikipedia Preview partner
I want the option to enable Wikipedia Preview on links
So I don't have to wait for more complex features

Acceptance criteria

When Wikipedia links exist on a page (or always, if that conditional is not possible) the plugin loads the wikipediaPreview.production.js file and initializes it with the following options
- root: document.querySelector('.entry-content')
- detectLinks: true

Notes

The goal of this task is to be able to release a working plugin quickly before we deal with the custom editors. We need to think of a migration path between this version and the next so it keeps working if we stop detecting links by default. We could save a hidden setting for it.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		SBisson	T278383 Wikipedia Preview WordPress Plugin
		Resolved		hueitan	T280000 Plugin detect links

Event Timeline

SBisson created this task.Apr 13 2021, 10:24 AM

SBisson triaged this task as Medium priority.Apr 13 2021, 10:33 AM

SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Apr 26 2021, 3:31 PM

hueitan claimed this task.Apr 26 2021, 6:15 PM

hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

I removed the lang init param from the task description. When we detect links, we use the language in the URLs.

PR done in https://github.com/wikimedia/wikipediapreview-wordpress/pull/2

The PR is merged

how can I test this?

In T280000#7078538, @Jpita wrote:

how can I test this?

You install and activate the plugin in WordPress. Write an article with some links to Wikipedia. They should have previews on them.

• Jpita mentioned this in T282675: URL double encode issue on wp-preview.May 12 2021, 11:48 AM

T282675 was created to fix an issue found on this task

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.May 24 2021, 10:30 AM

• AMuigai closed this task as Resolved.May 27 2021, 7:35 PM