Page MenuHomePhabricator

Year- and Month- precision date queries return wrong results for "before" relation
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Query for a date value consisting of only a year and a year and a month and property-value-relation "before"
  • e.g. https://w-beta.wmflabs.org/Hx

What happens?:

  • if "before" is selected then one sees results after the given date

What should have happened instead?:

  • one sees items with a date before the date that one entered

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Michael renamed this task from Year- and Month- precision date queries have before/after swapped to Year- and Month- precision date queries return wrong results for "before" relation.Apr 13 2021, 2:57 PM
Michael updated the task description. (Show Details)

Change 678865 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Don't show dates after the given date when selecting "before"

https://gerrit.wikimedia.org/r/678865

Fixed issue and moved to peer review according to the "small things" experiment. This fix consists of swapping two lines. That's it. (+added autogenerated tests)

Change 678865 merged by jenkins-bot:

[wikidata/query-builder@master] Don't show dates after the given date when selecting "before"

https://gerrit.wikimedia.org/r/678865

amy_rc claimed this task.
amy_rc moved this task from Backlog to Done on the Wikidata Query Builder board.
amy_rc subscribed.

tested and worked for the scenario mentioned. 🎉