Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Daimona | T279423 Enable coverage reports for taint-check | |||
Resolved | Daimona | T269489 composer-package-phpXX-docker jobs run with xdebug enabled | |||
Resolved | Daimona | T280170 Add pcov to composer images | |||
Open | None | T243847 Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI |
Event Timeline
AFAICS, it can be installed either in the composer-package-phpXX images or the more base phpXX (which is where xdebug is also installed). Regardless of this, it cannot be installed for PHP 7.2 because it doesn't use sury-php, so this change would affect PHP >= 7.3. https://gerrit.wikimedia.org/g/integration/config/+/da9ffb4ef300862a1c4ba164d6f697b50091584f/jjb/misc.yaml#45 should be updated, too.
Thinking about this again, I think it would make more sense to install pcov in the base phpXY images, since xdebug is installed there, and it'd be easier to reuse. My next question is: is there a specific reason for not using sury-php in the PHP 7.2 image? Being able to install pcov there would possiblycould make it easier to run tests with coverage; for instance, for T279423 I'd have to hack the phpunit command so it doesn't generate coverage on PHP 7.2.
Change 679725 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[integration/config@master] [WIP] dockerfiles: Install pcov in base PHP images + composer-package
Change 694621 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[integration/config@master] [WIP] dockerfiles: Install pcov in base PHP images + composer-package
Change 679725 abandoned by Daimona Eaytoy:
[integration/config@master] [WIP] dockerfiles: Install pcov in base PHP images + composer-package
Reason:
Re-doing was easier than rebasing. I2c864784fab8f8be7ae641888b5949f47a81b2fb
Change 814124 had a related patch set uploaded (by Hashar; author: Hashar):
[integration/config@master] dockerfiles: cascade for installing pcov in PHP images
Change 694621 merged by jenkins-bot:
[integration/config@master] dockerfiles: Install pcov in base PHP images
Mentioned in SAL (#wikimedia-releng) [2022-07-15T12:20:28Z] <hashar> rebuilding php?? images for pcov https://gerrit.wikimedia.org/r/c/integration/config/+/694621 # T280170
Change 814124 merged by jenkins-bot:
[integration/config@master] dockerfiles: cascade for installing pcov in PHP images
Mentioned in SAL (#wikimedia-releng) [2022-07-15T15:59:34Z] <hashar> Built pcov php docker images T280170
Change 814730 had a related patch set uploaded (by Hashar; author: Hashar):
[integration/config@master] jjb: update php jobs to have php-pcov included
Change 814730 merged by jenkins-bot:
[integration/config@master] jjb: update php jobs to have php-pcov included
Since we don't need to worry about PHP 7.2 anymore, and pcov is now available in the other images, I'm calling this resolved.