Page MenuHomePhabricator
Create Task
Maniphest T280199

Implement a way for test comments to be posted automatically
Closed, ResolvedPublic
Actions

Description

This task is about implementing a way for test comments to be posted to patchdemo wiki talk pages, automatically.

We think doing the above will make it easier for Junior and Senior Contributors to experience the new topic subscription functionality without having to: A) post comments with a secondary account or B) depend on another person to post comments.

Requirements

The table below describes how the automatic posting should behave. Note, the table below can be finalized once the usability test script is written in T273912.

Test participant's actionSoftware's responsePurpose
When a test participant subscribes to a section on a patchdemo article talk page and posts a comment in that section......the software should post a comment in the section they just subscribed to...so the test participant can experience what it's like to receive a new comment notification via Echo
When a test participant posts a comment in an existing section on their patchdemo user talk page......the software should post a comment in the section they just commented in...so the test participant can experience what it's like to receive a new comment notification via Echo

Open questions

  • 1. What is the "final" set of interactions that should be automated (once this question is answered, the table in the ===Requirements section should be complete.
    • Done. Table is up to date.
Done
  • All ===Open questions are answered
  • The behavior described in the ===Requirements table is implemented

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DiscussionToolsmaster+53 -0[DO NOT MERGE] Post test comments automatically
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Apr 14 2021, 11:38 PM
ppelberg moved this task from Incoming to Upcoming on the Editing-team (FY2021-22 Kanban Board) board.
DannyS712 added a subscriber: DannyS712.Apr 15 2021, 5:23 AM

What about adding an internal api module that accepts as parameters the title and section (and token) and posts a comment along the lines of "Hey @User, here is an example comment" from a system user account?

matmarex mentioned this in T273912: Topic Subscriptions: Design usability test (Junior Contributors).Apr 16 2021, 7:03 PM
• iamjessklein mentioned this in T279164: Topic subscription: validate usability of topic subscription prototype with Juniors .Apr 16 2021, 7:16 PM
• iamjessklein added subscribers: Esanders, matmarex.Apr 19 2021, 3:53 PM

Based on the protocol that I've drafted over in T273912, I believe we have 2 triggers:

  1. Trigger: Reply to convo on USER talk Action: Notification in notifications "inbox"
  1. Condition: Tester subscribes to convo on ARTICLE talk Trigger: Reply to convo on ARTICLE talk Action: Notification in notifications "inbox"

Note: I don't believe that we need a ACTION/TRIGGER for sending a message after the tester unsubscribes from a thread, other than the typical unsubscribing affordances.

@ppelberg @Esanders @matmarex - please let me know if this seems logical.

ppelberg updated the task description. (Show Details)Apr 21 2021, 12:57 AM
In T280199#7014875, @iamjessklein wrote:

Based on the protocol that I've drafted over in T273912, I believe we have 2 triggers...

@iamjessklein: noted. I've updated the task description to reflect the triggers you described.

I think this is ready for engineering to start working on.

ppelberg moved this task from Upcoming to Ready to Be Worked On on the Editing-team (FY2021-22 Kanban Board) board.Apr 21 2021, 4:49 PM
matmarex claimed this task.Apr 27 2021, 8:50 PM
ppelberg moved this task from Ready to Be Worked On to Doing on the Editing-team (FY2021-22 Kanban Board) board.Apr 28 2021, 4:59 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Apr 28 2021, 5:39 PM
gerritbot added a comment.Apr 29 2021, 12:31 AM

Change 683448 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] [DO NOT MERGE] Post test comments automatically

https://gerrit.wikimedia.org/r/683448

gerritbot added a project: Patch-For-Review.Apr 29 2021, 12:31 AM
PatchDemoBot added a comment.Apr 29 2021, 12:48 AM

Test wiki created on Patch Demo by Matma Rex using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/0f020e4c8f/w/

Whatamidoing-WMF added a subscriber: Whatamidoing-WMF.Apr 29 2021, 5:18 PM

When it posts a reply comment, what does it say?

matmarex added a comment.EditedApr 29 2021, 5:21 PM

We discussed the patch with @iamjessklein, I need to make a new demo wiki with the following added changes:

  • unsubscribe action T279150
  • new button design T279149
  • highlight after following a notification T281471
  • Remove the automatic comment when "a test participant subscribes to a section", we decided we only need comments after replying
In T280199#7046444, @Whatamidoing-WMF wrote:

When it posts a reply comment, what does it say?

Jess is still deciding on the wording, it's somewhere in the "protocol doc" on T273912, right now it's just a placeholder text: "Hello! This is an automatic reply posted as a test, after you commented in a topic."

matmarex updated the task description. (Show Details)Apr 29 2021, 5:29 PM
matmarex added a comment.Apr 29 2021, 6:37 PM

Patch Demo, version 2:

https://patchdemo.wmflabs.org/wikis/510f14d928/w/

• iamjessklein mentioned this in T281438: Topic Subscriptions: Run manual topic subscription usability test with Junior Contributors.Apr 29 2021, 11:55 PM
• iamjessklein added a comment.Apr 30 2021, 12:34 AM

This is looking great @matmarex

✔️The highlight works
✔️ Unsubscribe from notification window works
✔️ The correct unsubscribe button is there

The bot

  • I tried to make the bot display more like a regular account but it is a brown link now. Do I need to do something else to make it display like a typical user?
  • The comment should say:

Great. Go back to the Article talk page and share the source here so that we can publicly work on it.

Setting up the Nellie Bly page
I tried doing the export/import, but once again it failed. The page is there but all the links are broken, can you take a look?

Test accounts
I need to create a minimum of 1 test account (but ideally a few). How should I go about doing that?

• iamjessklein mentioned this in T279150: Topic Subscriptions: Unsubscribe from Notifications from within dropdown.Apr 30 2021, 12:35 AM
• iamjessklein mentioned this in T279149: Topic Subscriptions: Improve user interface element for subscribing and unsubscribing to topics on Talk Pages .
• iamjessklein mentioned this in T281471: Topic Subscription Prototype: Highlight thread after following a notification .
• iamjessklein added a comment.Apr 30 2021, 12:46 AM

Actually, the highlight does not work. I just tested it on by:

  1. Go the User Talk Page and reply
  2. Navigate away
  3. See the notifications (bell and yellow banner)
  4. Click on bell and notification
  5. Go to reply but there's no highlight here.
matmarex added a comment.Apr 30 2021, 4:56 PM

(Copying my replies from Slack for future reference)

I tried to make the bot display more like a regular account but it is a brown link now. Do I need to do something else to make it display like a typical user?

I was going to say we should just create its user page, but I see you've already done that, and I see it as a normal blue link on https://patchdemo.wmflabs.org/wikis/510f14d928/wiki/Talk:Nellie_Bly. So I think this works now? Maybe you just had to refresh the page

The comment should say:
Great. Go back to the Article talk page and share the source here so that we can publicly work on it.

If I remember it right, you mentioned something about having a different message for the article talk page and the user talk page, is that still on the table?

I tried doing the export/import, but once again it failed. The page is there but all the links are broken, can you take a look?

Actually a different thing happened! It looks like you exported only the article and the talk page, without templates. Make sure you check the "Include templates" option when doing the export.

I need to create a minimum of 1 test account (but ideally a few). How should I go about doing that?

Go to "Create account" and create them, I'm afraid we don't have a way to automate it :/

Actually, the highlight does not work. I just tested it on by: (…)

Arrrgh it doesn't work for user talk pages, because that's the "old" kind of notification, and not the one we added :/ This is annoying, I'm not sure how to fix it

matmarex mentioned this in T281590: Enhance own user talk page comment notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it).Apr 30 2021, 4:57 PM
In T280199#7049322, @matmarex wrote:

Actually, the highlight does not work. I just tested it on by: (…)

Arrrgh it doesn't work for user talk pages, because that's the "old" kind of notification, and not the one we added :/ This is annoying, I'm not sure how to fix it

Okay, I figured out a nice way. (And also filed a separate task for this: T281590.)

matmarex added a comment.Apr 30 2021, 5:14 PM

Patch Demo, version 3:

https://patchdemo.wmflabs.org/wikis/f78b3c228c/w/

• iamjessklein added a comment.Apr 30 2021, 5:40 PM

great, I'll test against the protocol now.

ppelberg moved this task from Doing to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.May 13 2021, 5:31 PM
ppelberg closed this task as Resolved.May 14 2021, 2:10 AM
ppelberg updated the task description. (Show Details)
gerritbot added a comment.May 25 2021, 6:34 PM

Change 683448 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@master] [DO NOT MERGE] Post test comments automatically

Reason:

https://gerrit.wikimedia.org/r/683448

Maintenance_bot removed a project: Patch-For-Review.May 25 2021, 7:10 PM
PatchDemoBot added a comment.Sep 13 2021, 11:26 PM

Test wiki on Patch Demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0f020e4c8f/w/

ppelberg mentioned this in T290043: [SPIKE] What do senior contributors think of the auto-subscription implementation?.Sep 22 2021, 1:40 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL