Page MenuHomePhabricator

Move php-ast install scripts from Wikispeech
Open, Needs TriagePublic

Description

Why do we need a seperate bash script to install pecl ast into Vagrant? Why can't this be done properly into the MediaWiki-Vagrant repo rather than in the extension? The whole script seems to be superfluous as to what could be done in the puppet config inside Vagrant

Also, why are you using the pecl ast, rather than the debian package? https://packages.debian.org/buster/php-ast

T234240: Phan should work out of the box on MediaWiki-Vagrant for phan not working out of the box...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy renamed this task from Integrate Wikispeech properly into Vagrant to Move phan scripts from Wikispeech.Apr 15 2021, 1:49 AM

I guess based on the other bugs, these scripts should at least live in Vagrant itself (even if not automagically plumbed in) not in some "random" extension when others may want to make use of it

Reedy renamed this task from Move phan scripts from Wikispeech to Move php-ast install scripts from Wikispeech.Apr 15 2021, 1:51 AM

With phan now working out of the box and there being a phan puppet role we can probably drop dev/activate_ast_on_vagrant.(md|sh) after updating the docs to make clear that this new role needs to be used.

With phan now working out of the box and there being a phan puppet role we can probably drop dev/activate_ast_on_vagrant.(md|sh) after updating the docs to make clear that this new role needs to be used.

Happened to have a fresh Vagrant install and running the /dev/phan.sh job works fine now without any further work (other than running composer update in the Wikispeech directory and activating the phan puppet role.

MediaWiki-Vagrant Buster now has a separate role for phan that installs php-ast: T321987: Create a separate role for phan that also increases the memory limit, the scripts are no longer necessary.