Maniphest T280282

Special:EditGrowthConfig should not use cache for loading the form
Closed, ResolvedPublic
Actions

Description

Right now, Special:EditGrowthConfig uses cache for loading the configuration form. That is dangerous, as when user submits the form, it can cause unintended variables to change.

This was noticed when testing this with @MMiller_WMF, see T280150#7003815.

Details

	Subject	Repo	Branch	Lines +/-
	Special:EditGrowthConfig should not use cache to load config	mediawiki/extensions/GrowthExperiments	master	+82 -19

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Trizek-WMF	T246939 [Growth scaling] streamlined configuration
		Resolved		Urbanecm_WMF	T282986 Add description field on NewcomerTasksInfo special page
		Resolved		Urbanecm_WMF	T274520 Move Growth configuration to on-wiki JSON file
		Resolved		Urbanecm_WMF	T274031 Provide custom editing interface for GrowthExperiments on-wiki configuration
		Resolved		Urbanecm_WMF	T280282 Special:EditGrowthConfig should not use cache for loading the form

Event Timeline

Urbanecm_WMF created this task.Apr 15 2021, 6:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2021, 6:31 PM

Causes unexpected behavior for the configuration editor => high priority.

Change 679920 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Special:EditGrowthConfig should not use cache to load config

https://gerrit.wikimedia.org/r/679920

gerritbot added a project: Patch-For-Review.Apr 15 2021, 6:46 PM

Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 15 2021, 6:47 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM

Urbanecm_WMF mentioned this in T280150: Test the on-wiki configuration editor.Apr 16 2021, 12:43 PM

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.Apr 19 2021, 8:28 PM

• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:36 PM

Change 679920 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Special:EditGrowthConfig should not use cache to load config

https://gerrit.wikimedia.org/r/679920

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 25 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2021, 6:10 PM

Urbanecm_WMF closed this task as Resolved.Apr 25 2021, 10:00 PM

Urbanecm_WMF edited projects, added GrowthExperiments-CommunityConfiguration; removed GrowthExperiments.Aug 3 2021, 11:02 PM