Again, likely as a result of the legacy split.
Description
Details
Related Objects
- Mentioned In
- T300169: Should UI regressions (e.g. no fatals) with the non-default skins ever block the train?
T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had
T280285: In in Timeless, Modern, CologneBlue Table of contents now has smaller font size and centered heading - Mentioned Here
- T280723: 'legacy' skin feature is not backwards compatible with itself, with new content from other features, and missing other content it previously had
Event Timeline
Before, no explicit border (which I disliked), a more 'embossed' look, and the indicator for the expansion was not that icon IIRC, if present at all.
Change 683777 had a related patch set uploaded (by Isarra; author: Isarra):
[mediawiki/skins/Timeless@master] Support mw 1.36/1.37: Disable all skin features except for a couple in favour of mw 1.34 shared.css to avoid weird inconsistent visual styles
Change 685614 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Legacy feature should not load thumbnail style rules
Change 683777 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Support mw 1.36/1.37: Disable all skin features except for a couple in favour of mw 1.34 shared.css to avoid weird inconsistent visual styles
Is the legacy feature still being deprecated? If so I'm not really sure I see the point doing anything there specifically...
Also still can't actually use 'legacy' in Timeless unless all the other features with monobook styles are also removed/have their boxes separated out, but even this seems like it might be good to backport to 1.36 as is for better backwards compatibility for such skins in general at this point.
The legacy feature is still being deprecated but as with any other deprecation we have been trying to do this in such a way that skins can take the year or two they need to cach up. If a skin is using legacy, minor padding changes and a border here and there might be okay, but this one does seem like a substantial unwarranted change which changed look and feel following further investigation (in short you've convinced me).
I am still not sure what else is a problem with T280723 but let's focus on this one for now :)
Change 690085 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@wmf/1.36.0-wmf.36] Legacy feature should not load thumbnail style rules (only layout)
Change 685614 merged by jenkins-bot:
[mediawiki/core@master] Legacy feature should not load thumbnail style rules (only layout)
Change 690085 abandoned by Jforrester:
[mediawiki/core@wmf/1.36.0-wmf.36] Legacy feature should not load thumbnail style rules (only layout)
Reason:
Change 690797 had a related patch set uploaded (by Jforrester; author: Jdlrobson):
[mediawiki/core@REL1_36] Legacy feature should not load thumbnail style rules (only layout)
Change 690797 merged by jenkins-bot:
[mediawiki/core@REL1_36] Legacy feature should not load thumbnail style rules (only layout)