Page MenuHomePhabricator

Big increase in eventlogging_SearchSatisfaction validation errors after this week's MW train
Closed, ResolvedPublic

Description

https://grafana.wikimedia.org/goto/b0HTt2XMk

https://logstash.wikimedia.org/goto/745fc310c843622e89d598b25392687a

Looks like event.userEditBucket is being set to null, which is not allowed. The field should be omitted if it is not required and should not be set.

See also https://wikitech.wikimedia.org/wiki/Event_Platform/Schemas/Guidelines#No_union_types_/_No_null_values

Event Timeline

It looks like the source of this is I2bcd7305 from T210106. It looks like this changed the logged value from '0 edits' to null for many logged requests. I don't know who is using this info downstream, safest approach seems to be to transform null back into '0 edits'.

Change 679971 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/WikimediaEvents@master] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679971

Change 679845 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/WikimediaEvents@wmf/1.37.0-wmf.1] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679845

Change 679971 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679971

Change 679845 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.37.0-wmf.1] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679845

Mentioned in SAL (#wikimedia-operations) [2021-04-15T23:31:16Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/WikimediaEvents/modules/ext.wikimediaEvents/searchSatisfaction.js: Backport: [[gerrit:679845|searchSatisfaction: Default userEditBucket back to 0 edits (T280294)]] (duration: 00m 57s)

Change 680180 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/WikimediaEvents@master] Omit SearchSatisfaction userEditBucket field for anons

https://gerrit.wikimedia.org/r/680180

Change 680180 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Omit userEditCountBucket field for anons and when unavailable

https://gerrit.wikimedia.org/r/680180

All related patches in Gerrit have been merged. Can this task be resolved (via Add Action...Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

@EBernhardson: No reply; assuming this is resolved. If not then please reopen. Thanks!