Page MenuHomePhabricator
Create Task
Maniphest T280294

Big increase in eventlogging_SearchSatisfaction validation errors after this week's MW train
Closed, ResolvedPublic
Actions

Description

https://grafana.wikimedia.org/goto/b0HTt2XMk

https://logstash.wikimedia.org/goto/745fc310c843622e89d598b25392687a

Looks like event.userEditBucket is being set to null, which is not allowed. The field should be omitted if it is not required and should not be set.

See also https://wikitech.wikimedia.org/wiki/Event_Platform/Schemas/Guidelines#No_union_types_/_No_null_values

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
searchSatisfaction: Default userEditBucket back to 0 editsmediawiki/extensions/WikimediaEventsmaster+1 -1
Omit userEditCountBucket field for anons and when unavailablemediawiki/extensions/WikimediaEventsmaster+25 -10
searchSatisfaction: Default userEditBucket back to 0 editsmediawiki/extensions/WikimediaEventswmf/1.37.0-wmf.1+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ottomata created this task.Apr 15 2021, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2021, 8:59 PM
RhinosF1 subscribed.Apr 15 2021, 9:03 PM
EBernhardson added a comment.EditedApr 15 2021, 9:33 PM

It looks like the source of this is I2bcd7305 from T210106. It looks like this changed the logged value from '0 edits' to null for many logged requests. I don't know who is using this info downstream, safest approach seems to be to transform null back into '0 edits'.

gerritbot added a comment.Apr 15 2021, 9:40 PM

Change 679971 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/WikimediaEvents@master] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679971

gerritbot added a project: Patch-For-Review.Apr 15 2021, 9:40 PM
gerritbot added a comment.Apr 15 2021, 10:52 PM

Change 679845 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/WikimediaEvents@wmf/1.37.0-wmf.1] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679845

gerritbot added a comment.Apr 15 2021, 10:57 PM

Change 679971 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679971

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 15 2021, 11:00 PM
gerritbot added a comment.Apr 15 2021, 11:27 PM

Change 679845 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.37.0-wmf.1] searchSatisfaction: Default userEditBucket back to 0 edits

https://gerrit.wikimedia.org/r/679845

Stashbot added a comment.Apr 15 2021, 11:31 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-15T23:31:16Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/WikimediaEvents/modules/ext.wikimediaEvents/searchSatisfaction.js: Backport: [[gerrit:679845|searchSatisfaction: Default userEditBucket back to 0 edits (T280294)]] (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 16 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 16 2021, 12:10 AM
gerritbot added a comment.Apr 16 2021, 6:45 AM

Change 680180 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/WikimediaEvents@master] Omit SearchSatisfaction userEditBucket field for anons

https://gerrit.wikimedia.org/r/680180

gerritbot added a project: Patch-For-Review.Apr 16 2021, 6:45 AM
awight mentioned this in T210106: Provide a reusable getEditCountBucket function for analytics purposes.Apr 16 2021, 7:08 AM
gerritbot added a comment.Apr 16 2021, 11:37 AM

Change 680180 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Omit userEditCountBucket field for anons and when unavailable

https://gerrit.wikimedia.org/r/680180

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 16 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 16 2021, 12:10 PM
Aklapper added a project: MediaWiki-extensions-WikimediaEvents.May 24 2021, 7:16 AM

All related patches in Gerrit have been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Aklapper closed this task as Resolved.Jul 20 2021, 11:56 AM

@EBernhardson: No reply; assuming this is resolved. If not then please reopen. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits