Page MenuHomePhabricator
Create Task
Maniphest T280312

Handle EditFilterMergedContent hook properly to display error message
Closed, ResolvedPublic
Actions

Description

Acording to T273354, handler of EditFilterMergedContent hook now can simply return false to abort the hook chain.

Set $status->value manually still to provide backward compatibility.

Details

SubjectRepoBranchLines +/-
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/JsonConfigREL1_36+4 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/EventLoggingREL1_36+10 -4
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/SpamBlacklistREL1_36+2 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/UploadWizardREL1_36+3 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/AbuseFilterREL1_35+4 -0
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/EventLoggingmaster+10 -4
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/SpamBlacklistmaster+3 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/AbuseFilterREL1_36+4 -0
Handle EditFilterMergedContent hook properly to display error messagemediawiki/extensions/AkismetKlikmaster+6 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/AbuseFiltermaster+5 -0
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/Scribuntomaster+5 -0
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/Translatemaster+5 -0
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/JsonConfigmaster+4 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/UploadWizardmaster+4 -1
Handle EditFilterMergedContent hook properly to display error messagemediawiki/extensions/Gadgetsmaster+2 -0
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/LinkedWikimaster+4 -0
Handle EditFilterMergedContent hook properly to display error messagemediawiki/extensions/Newslettermaster+3 -1
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/GrowthExperimentsREL1_36+10 -4
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/MediaUploadermaster+36 -43
Handle EditFilterMergedContent hook properly to break hook chains and display error messagemediawiki/extensions/GrowthExperimentsmaster+7 -5
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Func created this task.Apr 16 2021, 5:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2021, 5:27 AM
gerritbot added a comment.Apr 16 2021, 5:28 AM

Change 680013 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Translate@master] Handle EditFilterMergedContent hook porperly to display error message

https://gerrit.wikimedia.org/r/680013

gerritbot added a project: Patch-For-Review.Apr 16 2021, 5:28 AM
gerritbot added a comment.Apr 16 2021, 5:37 AM

Change 680014 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Newsletter@master] Handle EditFilterMergedContent hook porperly to display error message

https://gerrit.wikimedia.org/r/680014

gerritbot added a comment.Apr 16 2021, 5:43 AM

Change 680015 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Gadgets@master] Handle EditFilterMergedContent hook porperly to display error message

https://gerrit.wikimedia.org/r/680015

Func renamed this task from Handle EditFilterMergedContent hook porperly to display error message to Handle EditFilterMergedContent hook properly to display error message.Apr 16 2021, 3:12 PM
gerritbot added a comment.Apr 16 2021, 3:19 PM

Change 680347 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AbuseFilter@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680347

gerritbot added a comment.Apr 16 2021, 3:30 PM

Change 680348 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AkismetKlik@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680348

Func added a comment.Apr 16 2021, 3:39 PM

https://codesearch.wmcloud.org/extensions/?q=EditFilterMergedContent

gerritbot added a comment.Apr 17 2021, 5:10 AM

Change 680362 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GrowthExperiments@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680362

gerritbot added a comment.Apr 17 2021, 5:33 AM

Change 680363 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/MediaUploader@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680363

gerritbot added a comment.Apr 17 2021, 8:47 AM

Change 680364 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/EventLogging@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680364

gerritbot added a comment.Apr 17 2021, 9:41 AM

Change 680365 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/JsonConfig@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680365

gerritbot added a comment.Apr 17 2021, 9:58 AM

Change 680686 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/LinkedWiki@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680686

gerritbot added a comment.Apr 17 2021, 10:00 AM

Change 680687 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/SpamBlacklist@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680687

gerritbot added a comment.Apr 17 2021, 10:05 AM

Change 680688 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/UploadWizard@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680688

gerritbot added a comment.Apr 17 2021, 10:09 AM

Change 680689 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Scribunto@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680689

Func mentioned this in T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.Apr 17 2021, 12:29 PM
gerritbot added a comment.Apr 25 2021, 4:19 PM

Change 680362 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680362

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 25 2021, 5:00 PM
gerritbot added a comment.Apr 26 2021, 8:07 AM

Change 680363 merged by jenkins-bot:

[mediawiki/extensions/MediaUploader@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680363

Func mentioned this in rEMEU8c864e9d7092: Handle EditFilterMergedContent hook properly to break hook chains and display….Apr 26 2021, 8:07 AM
gerritbot added a comment.Apr 27 2021, 5:45 AM

Change 682721 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GrowthExperiments@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/682721

gerritbot added a comment.May 24 2021, 10:51 AM

Change 682721 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/682721

matmarex added a project: MediaWiki-General.Jun 26 2021, 11:39 AM
matmarex subscribed.
gerritbot added a comment.Jun 26 2021, 11:52 AM

Change 680014 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680014

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Jun 26 2021, 12:00 PM
gerritbot added a comment.Jun 26 2021, 12:00 PM

Change 680015 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680015

gerritbot added a comment.Jun 26 2021, 12:00 PM

Change 680688 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680688

gerritbot added a comment.Jun 26 2021, 12:00 PM

Change 680686 merged by jenkins-bot:

[mediawiki/extensions/LinkedWiki@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680686

gerritbot added a comment.Jun 26 2021, 12:14 PM

Change 680364 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680364

gerritbot added a comment.Jun 26 2021, 12:18 PM

Change 680365 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680365

gerritbot added a comment.Jun 26 2021, 12:21 PM

Change 680013 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680013

gerritbot added a comment.Jun 26 2021, 12:21 PM

Change 680689 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680689

gerritbot added a comment.Jun 26 2021, 12:21 PM

Change 701627 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AbuseFilter@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701627

gerritbot added a comment.Jun 26 2021, 12:21 PM

Change 680347 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680347

gerritbot added a comment.Jun 26 2021, 12:36 PM

Change 680348 merged by Bartosz Dziewoński:

[mediawiki/extensions/AkismetKlik@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680348

gerritbot added a comment.Jun 26 2021, 12:57 PM

Change 680687 merged by jenkins-bot:

[mediawiki/extensions/SpamBlacklist@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680687

Func mentioned this in rELIWe1937800f395: Handle EditFilterMergedContent hook properly to break hook chains and display….Jun 26 2021, 1:09 PM
gerritbot added a comment.Jun 26 2021, 1:14 PM

Change 701629 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AbuseFilter@REL1_35] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701629

gerritbot added a comment.Jun 26 2021, 1:17 PM

Change 701627 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701627

gerritbot added a comment.Jun 26 2021, 1:17 PM

Change 701630 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/SpamBlacklist@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701630

gerritbot added a comment.Jun 26 2021, 1:20 PM

Change 701631 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/UploadWizard@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701631

matmarex added a comment.Jun 26 2021, 1:22 PM

I've merged the AbuseFilter backport, but now I'm wondering whether it is necessary to backport these patches. As far as I can tell, this is not fixing a severe bug, so I would rather be cautious and not backport.

Func mentioned this in T271037: CVE-2021-44856: Title blocked in AbuseFilter can be created via Special:ChangeContentModel due to the mishandling of EditFilterMergedContent hook return value.Jun 26 2021, 1:36 PM
matmarex closed this task as Resolved.Jun 26 2021, 2:47 PM
Krinkle mentioned this in T286611: TypeError: Return value of JsonSchemaHooks::onEditFilterMergedContent() must be of the type boolean, none returned.Jul 14 2021, 6:43 PM
gerritbot added a comment.Sep 26 2021, 8:34 AM

Change 701629 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_35] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701629

gerritbot added a comment.Dec 10 2021, 9:44 AM

Change 701631 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701631

gerritbot added a comment.Dec 10 2021, 9:44 AM

Change 701630 merged by jenkins-bot:

[mediawiki/extensions/SpamBlacklist@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701630

gerritbot added a comment.Apr 9 2022, 4:25 PM

Change 778629 had a related patch set uploaded (by Umherirrender; author: Func):

[mediawiki/extensions/EventLogging@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/778629

gerritbot added a comment.Apr 9 2022, 4:36 PM

Change 778630 had a related patch set uploaded (by Umherirrender; author: Func):

[mediawiki/extensions/JsonConfig@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/778630

gerritbot added a comment.Apr 9 2022, 4:46 PM

Change 778629 abandoned by Umherirrender:

[mediawiki/extensions/EventLogging@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

Reason:

Does not help for that specific failures

https://gerrit.wikimedia.org/r/778629

gerritbot added a comment.Apr 9 2022, 4:46 PM

Change 778630 abandoned by Umherirrender:

[mediawiki/extensions/JsonConfig@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

Reason:

Does not help for that specific failures

https://gerrit.wikimedia.org/r/778630

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL