Page MenuHomePhabricator

Handle EditFilterMergedContent hook properly to display error message
Closed, ResolvedPublic

Description

Acording to T273354, handler of EditFilterMergedContent hook now can simply return false to abort the hook chain.

Set $status->value manually still to provide backward compatibility.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/JsonConfigREL1_36+4 -1
mediawiki/extensions/EventLoggingREL1_36+10 -4
mediawiki/extensions/SpamBlacklistREL1_36+2 -1
mediawiki/extensions/UploadWizardREL1_36+3 -1
mediawiki/extensions/AbuseFilterREL1_35+4 -0
mediawiki/extensions/EventLoggingmaster+10 -4
mediawiki/extensions/SpamBlacklistmaster+3 -1
mediawiki/extensions/AbuseFilterREL1_36+4 -0
mediawiki/extensions/AkismetKlikmaster+6 -1
mediawiki/extensions/AbuseFiltermaster+5 -0
mediawiki/extensions/Scribuntomaster+5 -0
mediawiki/extensions/Translatemaster+5 -0
mediawiki/extensions/JsonConfigmaster+4 -1
mediawiki/extensions/UploadWizardmaster+4 -1
mediawiki/extensions/Gadgetsmaster+2 -0
mediawiki/extensions/LinkedWikimaster+4 -0
mediawiki/extensions/Newslettermaster+3 -1
mediawiki/extensions/GrowthExperimentsREL1_36+10 -4
mediawiki/extensions/MediaUploadermaster+36 -43
mediawiki/extensions/GrowthExperimentsmaster+7 -5
Show related patches Customize query in gerrit

Event Timeline

Change 680013 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Translate@master] Handle EditFilterMergedContent hook porperly to display error message

https://gerrit.wikimedia.org/r/680013

Change 680014 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Newsletter@master] Handle EditFilterMergedContent hook porperly to display error message

https://gerrit.wikimedia.org/r/680014

Change 680015 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Gadgets@master] Handle EditFilterMergedContent hook porperly to display error message

https://gerrit.wikimedia.org/r/680015

Func renamed this task from Handle EditFilterMergedContent hook porperly to display error message to Handle EditFilterMergedContent hook properly to display error message.Apr 16 2021, 3:12 PM

Change 680347 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AbuseFilter@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680347

Change 680348 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AkismetKlik@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680348

Change 680362 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GrowthExperiments@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680362

Change 680363 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/MediaUploader@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680363

Change 680364 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/EventLogging@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680364

Change 680365 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/JsonConfig@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680365

Change 680686 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/LinkedWiki@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680686

Change 680687 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/SpamBlacklist@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680687

Change 680688 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/UploadWizard@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680688

Change 680689 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/Scribunto@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680689

Change 680362 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680362

Change 680363 merged by jenkins-bot:

[mediawiki/extensions/MediaUploader@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680363

Change 682721 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/GrowthExperiments@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/682721

Change 682721 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/682721

Change 680014 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680014

Change 680015 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680015

Change 680688 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680688

Change 680686 merged by jenkins-bot:

[mediawiki/extensions/LinkedWiki@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680686

Change 680364 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680364

Change 680365 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680365

Change 680013 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680013

Change 680689 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680689

Change 701627 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AbuseFilter@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701627

Change 680347 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680347

Change 680348 merged by Bartosz Dziewoński:

[mediawiki/extensions/AkismetKlik@master] Handle EditFilterMergedContent hook properly to display error message

https://gerrit.wikimedia.org/r/680348

Change 680687 merged by jenkins-bot:

[mediawiki/extensions/SpamBlacklist@master] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/680687

Change 701629 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/AbuseFilter@REL1_35] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701629

Change 701627 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701627

Change 701630 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/SpamBlacklist@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701630

Change 701631 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/UploadWizard@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701631

I've merged the AbuseFilter backport, but now I'm wondering whether it is necessary to backport these patches. As far as I can tell, this is not fixing a severe bug, so I would rather be cautious and not backport.

Change 701629 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_35] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701629

Change 701631 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701631

Change 701630 merged by jenkins-bot:

[mediawiki/extensions/SpamBlacklist@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/701630

Change 778629 had a related patch set uploaded (by Umherirrender; author: Func):

[mediawiki/extensions/EventLogging@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/778629

Change 778630 had a related patch set uploaded (by Umherirrender; author: Func):

[mediawiki/extensions/JsonConfig@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

https://gerrit.wikimedia.org/r/778630

Change 778629 abandoned by Umherirrender:

[mediawiki/extensions/EventLogging@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

Reason:

Does not help for that specific failures

https://gerrit.wikimedia.org/r/778629

Change 778630 abandoned by Umherirrender:

[mediawiki/extensions/JsonConfig@REL1_36] Handle EditFilterMergedContent hook properly to break hook chains and display error message

Reason:

Does not help for that specific failures

https://gerrit.wikimedia.org/r/778630