Page MenuHomePhabricator
Create Task
Maniphest T280323

Remove dead code from WikiPagePropertyOrderProvider
Closed, ResolvedPublic
Actions

Description

WikiPagePropertyOrderProvider::getPropertyOrderWikitext() starts with a check that the $this->pageTitle is set; however, the constructor parameter is typehinted as Title (without = null), so it can’t possibly be null. The check must therefore be redundant, if I’m not mistaken.

Noticed while working on T280123.

Details

SubjectRepoBranchLines +/-
Remove dead code from WikiPagePropertyOrderProvidermediawiki/extensions/Wikibasemaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 16 2021, 9:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2021, 9:21 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 16 2021, 9:23 AM
gerritbot added a comment.Apr 16 2021, 9:23 AM

Change 680264 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove dead code from WikiPagePropertyOrderProvider

https://gerrit.wikimedia.org/r/680264

gerritbot added a project: Patch-For-Review.Apr 16 2021, 9:23 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Up for review on the Wikibase Service Migration board.Apr 16 2021, 9:23 AM
gerritbot added a comment.Apr 16 2021, 1:34 PM

Change 680264 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove dead code from WikiPagePropertyOrderProvider

https://gerrit.wikimedia.org/r/680264

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 16 2021, 1:43 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 16 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 16 2021, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL