Page MenuHomePhabricator
Create Task
Maniphest T280344

Quiet progressive/destructive buttons hover state inconsistent with style guide and implementations
Closed, ResolvedPublic
Actions

Description

Quiet buttons in the style guide use a different background on hover when they are progressive (light blue) or destructive (light red):

Screenshot 2021-04-16 at 12.49.03 2.png (353×796 px, 46 KB)

However, in WVUI these use grey instead as background:

Screenshot 2021-04-16 at 12.55.17 2.png (671×644 px, 45 KB)
Screenshot 2021-04-16 at 12.54.30 2.png (678×647 px, 45 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+66 -52Update WVUI to v0.1.1
wvuimaster+10 -2[components][button][styles] Fix hover and active for p/d quiet buttons
wvuimaster+28 -18[button] Fix appearance of progressive/destructive buttons
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Apr 16 2021, 10:58 AM
Sarai-WMDE mentioned this in T277047: Epic: Do a design inventory of Wikiverse (Design Style Guide, Codex, OOUI, WVUI, MediaWiki widgets) UI components.Apr 19 2021, 10:32 AM
gerritbot added a comment.Apr 19 2021, 8:56 PM

Change 681188 had a related patch set uploaded (by Catrope; author: Catrope):

[wvui@master] Fix appearance of progressive/destructive buttons

https://gerrit.wikimedia.org/r/681188

gerritbot added a project: Patch-For-Review.Apr 19 2021, 8:56 PM
gerritbot added a comment.Apr 21 2021, 7:01 PM

Change 681188 abandoned by Catrope:

[wvui@master] [button] Fix appearance of progressive/destructive buttons

Reason:

https://gerrit.wikimedia.org/r/681188

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 7:10 PM
gerritbot added a comment.Apr 21 2021, 7:11 PM

Change 681767 had a related patch set uploaded (by Catrope; author: Catrope):

[wvui@master] [components][button][styles] Fix hover and active for p/d quiet buttons

https://gerrit.wikimedia.org/r/681767

gerritbot added a project: Patch-For-Review.Apr 21 2021, 7:11 PM
Catrope claimed this task.Apr 21 2021, 7:22 PM
gerritbot added a comment.Apr 21 2021, 10:08 PM

Change 681767 merged by jenkins-bot:

[wvui@master] [components][button][styles] Fix hover and active for p/d quiet buttons

https://gerrit.wikimedia.org/r/681767

jenkins-bot mentioned this in rWVUI7feaced37deb: [components][button][styles] Fix hover and active for p/d quiet buttons.Apr 21 2021, 10:08 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 10:11 PM
gerritbot added a comment.Apr 23 2021, 8:15 PM

Change 682196 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update WVUI to v0.1.1

https://gerrit.wikimedia.org/r/682196

gerritbot added a project: Patch-For-Review.Apr 23 2021, 8:15 PM
gerritbot added a comment.Apr 23 2021, 9:10 PM

Change 682196 merged by jenkins-bot:

[mediawiki/core@master] Update WVUI to v0.1.1

https://gerrit.wikimedia.org/r/682196

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 9:10 PM
Volker_E closed this task as Resolved.Apr 25 2021, 9:13 PM
Volker_E triaged this task as Medium priority.
Volker_E renamed this task from Quiet buttons hover state inconsistent with style guide and implementations to Quiet progressive/destructive buttons hover state inconsistent with style guide and implementations.Apr 4 2022, 5:44 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL