Page MenuHomePhabricator

Maplinks work only on the very first preview when using the live preview
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Turn on live preview in the preferences (Editing / Show previews without reloading the page).
  2. Open up a page containing a maplink for editing (using the classic [2006/2010] wikitext editor), e.g. https://commons.wikimedia.org/w/index.php?title=File:18-as_villamos_(4097).jpg&action=submit
  3. Click on preview.
  4. Click on the maplink. So far so good, the map opens.
  5. Click on the preview once again.
  6. Click on the maplink once again.

Actual results

  1. Nothing happens, the maplink is unclickable.

Expected results

  1. The map opens, just like after the first preview.

Used software

  • Wikimedia Commons. The bug exists for a long time now, it’s not a new regression, I was just too lazy to report it before. 😉
  • Firefox ESR on Debian 10 (formerly 9), various versions (currently 78.9.0).

Event Timeline

@TheDJ, are you absolutely sure this is the same underlying bug? Because the symptoms described are quite different: in T151524, the map is responsive (can be moved around, zoomed, pins can be clicked etc.), only the actual map is missing; here, the maplink is not even responsive.

Fomafix added a subscriber: Fomafix.

T280363 is about maplinks. T151524 is about mapframe. These are separate bugs.

Change 693610 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Add new JavaScript hook `wikipage.indicators` to handle indicators

https://gerrit.wikimedia.org/r/693610

Change 693611 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/Kartographer@master] Use $content from hook instead of $('.mw-body') for maplink

https://gerrit.wikimedia.org/r/693611

Change 721324 had a related patch set uploaded (by Krinkle; author: Fomafix):

[mediawiki/core@REL1_37] mediawiki.page.ready: Introduce `wikipage.indicators` hook

https://gerrit.wikimedia.org/r/721324

Change 721325 had a related patch set uploaded (by Krinkle; author: Fomafix):

[mediawiki/core@REL1_36] mediawiki.page.ready: Introduce `wikipage.indicators` hook

https://gerrit.wikimedia.org/r/721325

Change 721324 merged by jenkins-bot:

[mediawiki/core@REL1_37] mediawiki.page.ready: Introduce `wikipage.indicators` hook

https://gerrit.wikimedia.org/r/721324

Change 693610 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.page.ready: Introduce `wikipage.indicators` hook

https://gerrit.wikimedia.org/r/693610

Change 721325 merged by jenkins-bot:

[mediawiki/core@REL1_36] mediawiki.page.ready: Introduce `wikipage.indicators` hook

https://gerrit.wikimedia.org/r/721325

Change 693611 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use $content from hook instead of $('.mw-body') for maplink

https://gerrit.wikimedia.org/r/693611