Page MenuHomePhabricator
Create Task
Maniphest T280365

Stop using global RequestContext in EditFilterHookRunner service wiring
Closed, ResolvedPublic
Actions

Description

Modify the EditFilterHookRunner so that we are able to construct it without passing a context, we can do this by passing the context into run instead and using that context to obtain the user. See WIP in 679751.

This probably involves changing MediawikiEditEntityFactory::newEditEntity to accept a context parameter instead of the first user parameter.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+65 -70Pass context into MediawikiEditEntity and EditFilterHookRunner
mediawiki/extensions/WikibaseLexememaster+11 -5Pass context instead of user into EntityRedirectCreationInteractor
mediawiki/extensions/Wikibasemaster+51 -14Make EntityRedirectCreationInteractor accept context argument
mediawiki/extensions/WikibaseLexememaster+7 -7Pass context instead of user into newEditEntity()
mediawiki/extensions/Wikibasemaster+30 -13Make newEditEntity() accept context argument
mediawiki/extensions/WikibaseLexememaster+1 -7Get EditFilterHookRunner from service container
Customize query in gerrit

Event Timeline

ItamarWMDE created this task.Apr 16 2021, 2:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2021, 2:22 PM
ItamarWMDE added a project: Wikidata.Apr 16 2021, 2:22 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 19 2021, 11:25 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.

Main plan:

  • Wikibase: make MediawikiEditEntityFactory::newEditEntity() accept first argument as IContextSource or User, and update callers
  • WikibaseLexeme: call newEditEntity() with a context instead of a user
  • Wikibase: make newEditEntity() pass context rather than user into EditFilterHookRunner; change EditFilterHookRunner::run()’s second argument from User to IContextSource; make it use that context everywhere (with the code to ensure it’s a MutableContext taken from the constructor); remove IContextSource constructor argument (fortunately it’s the last one, so removing it is not a breaking change)

Independently:

  • WikibaseLexeme: get MediawikiEditFilterHookRunner from service container
gerritbot added a comment.Apr 19 2021, 11:34 AM

Change 681029 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Get EditFilterHookRunner from service container

https://gerrit.wikimedia.org/r/681029

gerritbot added a project: Patch-For-Review.Apr 19 2021, 11:34 AM
Lucas_Werkmeister_WMDE added a comment.Apr 19 2021, 12:32 PM

Insert into the main plan:

  • Wikibase: make EntityRedirectCreationInteractor constructor accept fifth argument as IContextSource or User, and update callers
  • WikibaseLexeme: change MediaWikiLexemeRedirector constructor’s fifth argument from User to IContextSource
  • Wikibase: change EntityRedirectCreationInteractor constructor’s fifth argument to just IContextSource, update its call to EditFilterHookRunner::run()

I think the first two I’ll do as separate commits, and the last one merge into the other big Wikibase change.

gerritbot added a comment.Apr 19 2021, 1:10 PM

Change 681072 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make newEditEntity() accept context argument

https://gerrit.wikimedia.org/r/681072

gerritbot added a comment.Apr 19 2021, 1:10 PM

Change 681073 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make EntityRedirectCreationInteractor accept context argument

https://gerrit.wikimedia.org/r/681073

gerritbot added a comment.Apr 19 2021, 1:10 PM

Change 681074 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Pass context instead of user into newEditEntity()

https://gerrit.wikimedia.org/r/681074

gerritbot added a comment.Apr 19 2021, 1:10 PM

Change 681075 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Pass context instead of user into EntityRedirectCreationInteractor

https://gerrit.wikimedia.org/r/681075

gerritbot added a comment.Apr 19 2021, 1:10 PM

Change 681076 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Pass context into MediawikiEditEntity and EditFilterHookRunner

https://gerrit.wikimedia.org/r/681076

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 19 2021, 4:44 PM
gerritbot added a comment.Apr 20 2021, 8:20 AM

Change 681029 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Get EditFilterHookRunner from service container

https://gerrit.wikimedia.org/r/681029

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 20 2021, 9:00 AM
gerritbot added a comment.Apr 20 2021, 9:03 AM

Change 681072 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make newEditEntity() accept context argument

https://gerrit.wikimedia.org/r/681072

gerritbot added a comment.Apr 20 2021, 9:03 AM

Change 681074 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Pass context instead of user into newEditEntity()

https://gerrit.wikimedia.org/r/681074

gerritbot added a comment.Apr 20 2021, 11:40 AM

Change 681073 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make EntityRedirectCreationInteractor accept context argument

https://gerrit.wikimedia.org/r/681073

gerritbot added a comment.Apr 20 2021, 12:07 PM

Change 681075 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Pass context instead of user into EntityRedirectCreationInteractor

https://gerrit.wikimedia.org/r/681075

gerritbot added a comment.Apr 20 2021, 1:27 PM

Change 681076 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Pass context into MediawikiEditEntity and EditFilterHookRunner

https://gerrit.wikimedia.org/r/681076

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 20 2021, 1:43 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

Done, I think \o/

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2021, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL