Page MenuHomePhabricator

Search button should use Searchbutton instead of Search
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently, the new search uses the same label (search) that's used as the page title of Special:Search. It should use searchbutton.

searchbutton.png (236×1 px, 70 KB)

Screen Shot 2021-04-17 at 20.54.32.png (646×1 px, 86 KB)

QA steps

QA Results - Beta

ACStatusDetails
1T280405#7168485

QA Results - Prod

ACStatusDetails
1T280405#7174060

Event Timeline

Change 695546 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] Change search button msg key to `searchbutton`

https://gerrit.wikimedia.org/r/695546

ovasileva added a subscriber: ovasileva.
Jdlrobson added a subscriber: Jdlrobson.

To avoid self merging, I'm looking for another pair of eyes. Sam since you are planning to do code review this week, can you take a look?

Change 695546 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Change search button msg key to `searchbutton`

https://gerrit.wikimedia.org/r/695546

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: phuedx.

@phuedx / @Jdlrobson what size do I shrink the browser to, and how can I validate the label? Out of curiosity why uselang=fr?

Edtadros added a subscriber: Edtadros.

@Jdlrobson Need some clarification please: T280405#7138535 (<-- for your convenience, or you can look up an inch)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?uselang=fr, note switching to French is important, as we want to test longer search labels, and search is "rechercher" in French which is longer than normal
Shrink browser to 500px
✅ AC1: Check label.

Screen Shot 2021-06-21 at 9.55.59 PM.png (947×502 px, 171 KB)

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://test.wikipedia.org/wiki/Main_Page?uselang=fr, note switching to French is important, as we want to test longer search labels, and search is "rechercher" in French which is longer than normal
Shrink browser to 500px
✅ AC1: Check label.

Screen Shot 2021-06-23 at 5.32.59 PM.png (374×500 px, 52 KB)