@kostajh -- I see that this is Ready for Development. On which parts do you plan to take action? Do you need help prioritizing which scenarios need to be changed?

In T280422#7030443, @MMiller_WMF wrote:

@kostajh -- I see that this is Ready for Development.

per our new workflow, just trying to keep the Incoming column clear.

On which parts do you plan to take action? Do you need help prioritizing which scenarios need to be changed?

I was assuming the scenarios highlighted by Elena. I've put this on our schedule for next week, and yes please, clarification on exactly what should be changed would be very helpful.

We should also check what happens if the user abandons the edit (making VE store it as a draft edit) and then opens VE in normal mode (navigates to a different article and then returns, for example). I.e. T267690: Add a link in VE: don't write to or read from restored edits but with restoring being done by normal VE, not VE controlled by us.

@kostajh @Etonkovidova @Tgr -- I added a column to Elena's table listing the desired behavior. There is a basic rule that I think governs this that hopefully makes this simpler: If the user navigates away from the task, we are under no obligation to still have it there for them when they return to the article or to have saved any of their changes. If it's still there, that's bonus. We should rely on the browser's and VE's standard warnings about this, except in the case of when the user switches editors, because the behavior of our task deviates from VE's usual behavior (we discard their work instead of porting it into source mode).

How does this all sound?

In T280422#7044129, @MMiller_WMF wrote:

@kostajh @Etonkovidova @Tgr -- I added a column to Elena's table listing the desired behavior. There is a basic rule that I think governs this that hopefully makes this simpler: If the user navigates away from the task, we are under no obligation to still have it there for them when they return to the article or to have saved any of their changes. If it's still there, that's bonus. We should rely on the browser's and VE's standard warnings about this, except in the case of when the user switches editors, because the behavior of our task deviates from VE's usual behavior (we discard their work instead of porting it into source mode).

How does this all sound?

That sounds good.

On mobile, we should also make sure that /section/all is preserved. I noticed that clicking the "X" in suggestions mode, reloading the page, and pressing Edit (which brings me back to suggestions mode) will load the first section only, resulting in weird behavior if there are suggested links in sections farther down the page.

Change 684310 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Use section=all for edit link on read view in mobile

https://gerrit.wikimedia.org/r/684310

In T280422#7048834, @kostajh wrote:

On mobile, we should also make sure that /section/all is preserved. I noticed that clicking the "X" in suggestions mode, reloading the page, and pressing Edit (which brings me back to suggestions mode) will load the first section only, resulting in weird behavior if there are suggested links in sections farther down the page.

Done in https://gerrit.wikimedia.org/r/684310

Change 684310 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Use section=all for edit link on read view in mobile

https://gerrit.wikimedia.org/r/684310

@Etonkovidova we've made a bunch of changes since this was filed; could you please review the various scenarios (some are not applicable anymore – "Edit source" tab is gone for example) and let us know which, if any, need to be fixed?