Page MenuHomePhabricator
Create Task
Maniphest T280433

DiscussionTools makes talk page sections uncollapsible on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

Actual results:

  • No sections are shown under "Active discussions". If you click "Read as wiki page", the sections appear but they are not collapsed and cannot be collapsed.

Expected results:

  • The sections appear under "Active discussions". If you click "Read as wiki page", the sections appear in the collapsed state.

Reported in Wikipedia:Village pump (technical)#Could This Be A Glitch?

Details

SubjectRepoBranchLines +/-
CommentFormatter: Add 'ext-discussiontools-section' class instead of overwritingmediawiki/extensions/DiscussionToolswmf/1.37.0-wmf.1+5 -1
CommentFormatter: Add 'ext-discussiontools-section' class instead of overwritingmediawiki/extensions/DiscussionToolsmaster+5 -1
Remove <header> tags around headings for compat with MobileFrontendmediawiki/extensions/DiscussionToolswmf/1.37.0-wmf.1+376 -386
Remove <header> tags around headings for compat with MobileFrontendmediawiki/extensions/DiscussionToolsmaster+376 -386
Customize query in gerrit

Related Objects

Event Timeline

Nardog created this task.Apr 17 2021, 5:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2021, 5:35 AM
Nardog renamed this task from DiscussionTools makes talk page sections uncollapsible to DiscussionTools makes talk page sections uncollapsible on mobile.Apr 17 2021, 5:35 AM
SD0001 updated the task description. (Show Details)Apr 17 2021, 7:27 AM
Izno subscribed.Apr 17 2021, 2:15 PM
Aftabuzzaman subscribed.Apr 17 2021, 3:18 PM
matmarex subscribed.Apr 17 2021, 7:34 PM

Thank you for reporting this. Indeed, it's caused by some changes in DiscussionTools we made last week in preparation for the topic subscriptions feature. We'll investigate and fix the incompatibility or just revert the changes on Monday.

matmarex added a project: Editing-team (Kanban Board).Apr 17 2021, 7:34 PM
gerritbot added a comment.Apr 17 2021, 8:05 PM

Change 680767 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/680767

gerritbot added a project: Patch-For-Review.Apr 17 2021, 8:05 PM
Titore subscribed.Apr 18 2021, 7:07 PM
XanonymusX mentioned this in T280464: Section titles are wrongly wrapped and cause overflow in mobile version.Apr 18 2021, 8:35 PM
XanonymusX subscribed.
XanonymusX merged a task: T280464: Section titles are wrongly wrapped and cause overflow in mobile version.Apr 18 2021, 8:37 PM

It also causes weird overflow issues with long titles, btw, took me a while to figure out what could be wrong.

gerritbot added a comment.Apr 19 2021, 4:38 PM

Change 680767 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/680767

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 19 2021, 5:00 PM
gerritbot added a comment.Apr 19 2021, 5:05 PM

Change 681146 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/681146

matmarex mentioned this in T276455: MobileFrontend transformations interfere with DiscussionTools transformations.Apr 19 2021, 5:06 PM
Jdlrobson subscribed.Apr 19 2021, 5:07 PM

Is this also what broke collapsing on Village pump?

matmarex added a comment.Apr 19 2021, 5:09 PM

Scheduled: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210419T1800

In T280433#7015406, @Jdlrobson wrote:

Is this also what broke collapsing on Village pump?

Yes

Jdlrobson awarded a token.Apr 19 2021, 5:09 PM
gerritbot added a comment.Apr 19 2021, 6:01 PM

Change 681146 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/681146

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2021, 6:10 PM
Stashbot added a comment.Apr 19 2021, 6:13 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-19T18:13:57Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/DiscussionTools/: 66d137b75a7073c7162c443cc8c6ec6f3be714e0: Remove <header> tags around headings for compat with MobileFrontend (T280433) (duration: 00m 59s)

matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 19 2021, 6:19 PM

The issue should be fixed now. Sorry about that.

The HTML causing the issue is cached in the parser cache, so if you still see the bug on a particular page, you'll need to purge it (https://en.wikipedia.org/wiki/Wikipedia:Purge). Otherwise it will fix itself when the page is next edited, or after 30 days.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 19 2021, 7:00 PM
XanonymusX added a comment.EditedApr 19 2021, 7:23 PM

@matmarex Seems so, yes. However, now the main page on dewiki looks completely broken when I have the tool activated (on all skins). Somehow TemplateStyles are no longer loaded, I believe. According to the HTML output, there is DiscussionTools involved. The dewiki main page is in the Wikipedia namespace, that must be the reason it is affected.

Aschmidt subscribed.Apr 19 2021, 7:38 PM

I can confirm that the broken main page on dewiki is due to an error in discussion tools. :(

hgzh subscribed.Apr 19 2021, 7:39 PM

for dewiki main page, it seems like the class(es) are stripped from the h2 elements and replaced by ext-discussiontools-section which leads to the broken look.

XanonymusX added a comment.Apr 19 2021, 7:54 PM

Right, the same happens to other pages in the Wikipedia namespace that use class-styled h2 titles, like the Community portal.

matmarex added a comment.Apr 19 2021, 9:46 PM

Argh…

gerritbot added a comment.Apr 19 2021, 9:48 PM

Change 681201 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681201

gerritbot added a project: Patch-For-Review.Apr 19 2021, 9:48 PM
Aschmidt unsubscribed.Apr 19 2021, 9:57 PM
matmarex moved this task from Ready for Sign Off to Code Review on the Editing-team (Kanban Board) board.Apr 19 2021, 10:03 PM
gerritbot added a comment.Apr 19 2021, 10:37 PM

Change 681201 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681201

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 19 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 19 2021, 11:10 PM
gerritbot added a comment.Apr 19 2021, 11:23 PM

Change 681153 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681153

gerritbot added a project: Patch-For-Review.Apr 19 2021, 11:23 PM
gerritbot added a comment.Apr 20 2021, 11:49 AM

Change 681153 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681153

Stashbot added a comment.Apr 20 2021, 11:54 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-20T11:54:45Z] <wmde-fisch@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/DiscussionTools/includes/CommentFormatter.php: Backport: [[gerrit:681153|CommentFormatter: Add ext-discussiontools-section class instead of overwriting (T280433)]] (duration: 00m 57s)

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 20 2021, 11:56 AM

Thank you all for reporting it, the second issue should be fixed as well.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.1; 2021-04-13); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 20 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 20 2021, 12:10 PM
hgzh added a comment.Apr 20 2021, 1:24 PM

Yes, the pages are looking fine again. Thank you!

• ppelberg added a project: Editing QA.Apr 20 2021, 3:46 PM
• ppelberg moved this task from Ready for Sign Off to QA on the Editing-team (Kanban Board) board.
DLynch mentioned this in T280051: Make mobilefrontend talk overlay disableable.Apr 20 2021, 9:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Apr 21 2021, 6:44 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Apr 24 2021, 12:33 AM
• ppelberg claimed this task.
matmarex updated the task description. (Show Details)Apr 27 2021, 6:05 PM
matmarex mentioned this in T281204: [SPIKE] Determine whether collapsible sections in `Read as wikipage view` should be preserved.Apr 27 2021, 6:07 PM
Nardog updated the task description. (Show Details)Apr 28 2021, 6:13 AM
Nardog updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL