Page MenuHomePhabricator

DiscussionTools makes talk page sections uncollapsible on mobile
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce:

Actual results:

  • No sections are shown under "Active discussions". If you click "Read as wiki page", the sections appear but they are not collapsed and cannot be collapsed.

Expected results:

  • The sections appear under "Active discussions". If you click "Read as wiki page", the sections appear in the collapsed state.

Reported in Wikipedia:Village pump (technical)#Could This Be A Glitch?

Event Timeline

Nardog renamed this task from DiscussionTools makes talk page sections uncollapsible to DiscussionTools makes talk page sections uncollapsible on mobile.Sat, Apr 17, 5:35 AM

Thank you for reporting this. Indeed, it's caused by some changes in DiscussionTools we made last week in preparation for the topic subscriptions feature. We'll investigate and fix the incompatibility or just revert the changes on Monday.

Change 680767 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/680767

It also causes weird overflow issues with long titles, btw, took me a while to figure out what could be wrong.

Change 680767 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/680767

Change 681146 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/681146

Is this also what broke collapsing on Village pump?

Change 681146 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] Remove <header> tags around headings for compat with MobileFrontend

https://gerrit.wikimedia.org/r/681146

Mentioned in SAL (#wikimedia-operations) [2021-04-19T18:13:57Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/DiscussionTools/: 66d137b75a7073c7162c443cc8c6ec6f3be714e0: Remove <header> tags around headings for compat with MobileFrontend (T280433) (duration: 00m 59s)

The issue should be fixed now. Sorry about that.

The HTML causing the issue is cached in the parser cache, so if you still see the bug on a particular page, you'll need to purge it (https://en.wikipedia.org/wiki/Wikipedia:Purge). Otherwise it will fix itself when the page is next edited, or after 30 days.

@matmarex Seems so, yes. However, now the main page on dewiki looks completely broken when I have the tool activated (on all skins). Somehow TemplateStyles are no longer loaded, I believe. According to the HTML output, there is DiscussionTools involved. The dewiki main page is in the Wikipedia namespace, that must be the reason it is affected.

I can confirm that the broken main page on dewiki is due to an error in discussion tools. :(

for dewiki main page, it seems like the class(es) are stripped from the h2 elements and replaced by ext-discussiontools-section which leads to the broken look.

Right, the same happens to other pages in the Wikipedia namespace that use class-styled h2 titles, like the Community portal.

Change 681201 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681201

Change 681201 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681201

Change 681153 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681153

Change 681153 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.1] CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting

https://gerrit.wikimedia.org/r/681153

Mentioned in SAL (#wikimedia-operations) [2021-04-20T11:54:45Z] <wmde-fisch@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/DiscussionTools/includes/CommentFormatter.php: Backport: [[gerrit:681153|CommentFormatter: Add ext-discussiontools-section class instead of overwriting (T280433)]] (duration: 00m 57s)

Thank you all for reporting it, the second issue should be fixed as well.

Yes, the pages are looking fine again. Thank you!

ppelberg claimed this task.
Nardog updated the task description. (Show Details)