Page MenuHomePhabricator

ForkController should not assume existence of PCNTL support or posix extension
Closed, ResolvedPublic

Description

When running runJobs.php, ForkController throws errors

`// * This class requires the posix and pcntl extensions.`

But comment will not do anything. MediaWiki does not require pcntl and it's not enabled by default https://www.php.net/manual/en/pcntl.installation.php

PHP Warning:  Use of undefined constant SIGFPE - assumed 'SIGFPE' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGILL - assumed 'SIGILL' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGSEGV - assumed 'SIGSEGV' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGBUS - assumed 'SIGBUS' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGABRT - assumed 'SIGABRT' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGSYS - assumed 'SIGSYS' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGPIPE - assumed 'SIGPIPE' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGXCPU - assumed 'SIGXCPU' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2
PHP Warning:  Use of undefined constant SIGXFSZ - assumed 'SIGXFSZ' (this will throw an Error in a future version of PHP) in Psy Shell code on line 2

PHP8

PHP Error:  Undefined constant "SIGFPE" in Psy Shell code on line 2

posix is enabled by default, but I think since MediaWiki does not require it, it will be prudent to check it too.

Event Timeline

Change 680769 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] ForkController: Throw more meaningful error for missing PHP extensions

https://gerrit.wikimedia.org/r/680769

Change 680769 merged by jenkins-bot:

[mediawiki/core@master] ForkController: Throw more meaningful error for missing PHP extensions

https://gerrit.wikimedia.org/r/680769

Ammarpad claimed this task.