Page MenuHomePhabricator

Is it intended Quibble does not install the dependencies of the installed skins?
Closed, ResolvedPublic

Description

Hello, I am using Quibble on the top of Github actions to test my custom extensions/skin, and when I added a composer dependency to my skin, quibble fails at the phpunit test. (log is here)
At a short glance, it seems Quibble does not install dependencies for skins, the code creates composer.local.json just for extensions. (code) I want to know it is right and is intended.

Best regards.

From the build log, it has the repository mediawiki/skins/Femiwiki but the composer merge plugin doesn't load its composer.json since it is never injected in composer.local.json:

skin_not_injected.png (309×1 px, 102 KB)

Event Timeline

It is a fault indeed, the skins are never taken in account as you have pointed in the code! Looking at skins in our Gerrit under mediawiki/skins/* it looks like none define any composer requirement hence why we never have hit the issue.

Change 700605 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Add skins for composer merge plugin

https://gerrit.wikimedia.org/r/700605

Change 700605 merged by jenkins-bot:

[integration/quibble@master] Add skins for composer merge plugin

https://gerrit.wikimedia.org/r/700605

Change 704936 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

Change 704936 merged by jenkins-bot:

[integration/quibble@master] Release Quibble 1.0.0

https://gerrit.wikimedia.org/r/704936

hashar claimed this task.

The use case has been implemented and I believe that fixed it immediately for @Lens0021 since the script installs Quibble directly from source. It is now released as part of Quibble 1.0.0.