Page MenuHomePhabricator

Deploy new language switching functionality to logged-in users
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: Do not deploy until blockers are resolved. Tentative date: Wednesday, April 28

Background

We are planning on deploying the new language switching functionality. We will begin with logged-in users that have opted out of legacy vector

Acceptance criteria

  • Stage 1: deploy to testwiki and officewiki
    • Ensure full QA has been completed on these wikis
  • Stage 2: Deploy new language switching functionality to all users that have opted out of legacy vector
  • Exclude the following pilot wikis from the above:

Basque Wikipedia
French Wikipedia
French Wiktionary
Hebrew Wikipedia
Persian Wikipedia
Portuguese Wikiversity
Bengali Wikipedia
German Wikivoyage
Korean Wikipedia
Portuguese Wikipedia
Serbian Wikipedia
Turkish Wikipedia
Venetian Wikipedia
Wikimedia Incubator

Developer notes

The required config changes are:

Stage 1:

'wgVectorLanguageInHeader' => [
  'default' => [
    'logged_in' => false,
    'logged_out' => false,
  ],
  'testwiki' => [
    'logged_in' => true,
    'logged_out' => false,
  ],
  'officewiki' => [
    'logged_in' => true,
    'logged_out' => false,
  ],
],

Stage 2:

'wgVectorLanguageInHeader' => [
  'default' => [
    'logged_in' => true,
    'logged_out' => false,
  ],
  // Initially exclude those wikis in the Desktop Improvements group. See https://phabricator.wikimedia.org/T280526 for detail.
  'desktop-improvements' => [
    'logged_in' => false,
    'logged_out' => false,
  ],
],

Event Timeline

ovasileva set the point value for this task to 2.Mon, Apr 19, 5:45 PM

Change 682757 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable language in header for office and testwiki logged in users

https://gerrit.wikimedia.org/r/682757

Change 682758 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable new language button for all logged in users outside test projects

https://gerrit.wikimedia.org/r/682758

@ovasileva while writing this patch, a few things occurred to me.

  1. Deploying to logged in users only on Office/Test Wikipedia is a little strange. Since test.wikipedia.org is for testing and Office wiki is logged in users only, perhaps we want to deploy to all users there?
  1. I thought that the reason for deploying on logged in users first was to allow editors time to cleanup the top of the article (coordinates and page indicators) for our target wikis. The sooner we do this the better. What day is this planned for (do we have a task)? Note, In the event the top of the article is broken for the new language position (worse case imagine the situation where coordinates overlap language button), we can't start an A/B test as it might impact the results so the sooner we allow editors to clean up, the better.

@ovasileva while writing this patch, a few things occurred to me.

  1. Deploying to logged in users only on Office/Test Wikipedia is a little strange. Since test.wikipedia.org is for testing and Office wiki is logged in users only, perhaps we want to deploy to all users there?

Yup, stage 1 refers to all users on these wikis. Stage 2 is for people that have opted in.

  1. I thought that the reason for deploying on logged in users first was to allow editors time to cleanup the top of the article (coordinates and page indicators) for our target wikis. The sooner we do this the better. What day is this planned for (do we have a task)? Note, In the event the top of the article is broken for the new language position (worse case imagine the situation where coordinates overlap language button), we can't start an A/B test as it might impact the results so the sooner we allow editors to clean up, the better.

This is stage 2, which would be covered in this task. If we can get stage 1 done today, stage 2 would follow Thursday

Change 682757 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable language in header for office and testwiki users

https://gerrit.wikimedia.org/r/682757

Change 683036 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop default value for wgVectorLanguageInHeader

https://gerrit.wikimedia.org/r/683036

Change 683036 merged by jenkins-bot:

[operations/mediawiki-config@master] Use boolean values for wgVectorLanguageInHeader

https://gerrit.wikimedia.org/r/683036

Mentioned in SAL (#wikimedia-operations) [2021-04-27T18:32:29Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 91a85f2: ac770bf: Enable language in header for office and testwiki users (T280526) (duration: 01m 19s)

Not sure where to report this, but I noticed on test wiki that there is an escaping issue (32&#160;langues) that is visible in French: https://test.wikipedia.org/wiki/Main_Page?uselang=fr

Change 682758 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable new language button for all logged in users outside test projects

https://gerrit.wikimedia.org/r/682758

Mentioned in SAL (#wikimedia-operations) [2021-05-05T11:10:59Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 289dc34feeb0703bb45f4a71c149cd607ef26455: Enable new language button for all logged in users outside test projects (T280526) (duration: 02m 24s)