Page MenuHomePhabricator
Create Task
Maniphest T280581

Community configuration: Create an offswitch that would disable the feature
Closed, ResolvedPublic
Actions

Description

Background

As part of T274520: Move Growth configuration to on-wiki JSON file, the Growth team is creating a system to empower communities to edit configuration of the Growth team features.

As with any other feature, this system can have security vulnerabilities. To be able to quickly reduce the damage caused by such vulnerability, we should have an off switch to disable Special:EditGrowthConfig altogether.

Task objective

Implement a config variable that would shut down the special page, and make the system use configuration from global variables, as before the change.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Disable Special:EditGrowthConfig when on-wiki config is disabledmediawiki/extensions/GrowthExperimentsmaster+39 -1
Make it possible to disable on-wiki configurationmediawiki/extensions/GrowthExperimentsmaster+24 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Apr 19 2021, 6:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2021, 6:39 PM
Urbanecm_WMF added a parent task: T274520: Move Growth configuration to on-wiki JSON file.Apr 19 2021, 6:39 PM
MMiller_WMF subscribed.Apr 19 2021, 6:59 PM
kostajh renamed this task from Community configuration: Create a killswitch that would disable the feature to Community configuration: Create an offswitch that would disable the feature.Apr 19 2021, 8:13 PM
kostajh updated the task description. (Show Details)
kostajh subscribed.

(I've renamed this feature per guidance in https://inclusivenaming.org/language/evaluation-framework/)

kostajh triaged this task as Medium priority.Apr 20 2021, 9:10 AM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF claimed this task.Apr 20 2021, 12:03 PM
Urbanecm_WMF added a project: User-Urbanecm_WMF (Engineering).
In T280581#7016070, @kostajh wrote:

(I've renamed this feature per guidance in https://inclusivenaming.org/language/evaluation-framework/)

Thanks!

gerritbot added a comment.Apr 20 2021, 12:04 PM

Change 681346 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Make it possible to disable on-wiki configuration

https://gerrit.wikimedia.org/r/681346

gerritbot added a project: Patch-For-Review.Apr 20 2021, 12:04 PM
Urbanecm_WMF moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 20 2021, 12:04 PM
Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.
gerritbot added a comment.Apr 25 2021, 5:39 PM

Change 681346 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Make it possible to disable on-wiki configuration

https://gerrit.wikimedia.org/r/681346

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 25 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 25 2021, 6:10 PM
gerritbot added a comment.Apr 26 2021, 9:20 AM

Change 682538 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Disable Special:EditGrowthConfig when on-wiki config is disabled

https://gerrit.wikimedia.org/r/682538

gerritbot added a project: Patch-For-Review.Apr 26 2021, 9:20 AM
gerritbot added a comment.Apr 26 2021, 10:15 AM

Change 682538 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Disable Special:EditGrowthConfig when on-wiki config is disabled

https://gerrit.wikimedia.org/r/682538

Urbanecm_WMF closed this task as Resolved.Apr 26 2021, 11:02 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 11:11 AM
gerritbot added a comment.May 14 2024, 8:15 AM

Change #1031093 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Switch to a slightly less magic way of denoting how address should be updated

https://gerrit.wikimedia.org/r/1031093

gerritbot added a project: Patch-For-Review.May 14 2024, 8:15 AM
gerritbot added a comment.May 14 2024, 8:38 AM

Change #1031108 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move the main message import to the DonationQueue handler

https://gerrit.wikimedia.org/r/1031108

gerritbot added a comment.May 14 2024, 8:39 AM

Change #1031107 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Finally push the recurring donation to the donation queue

https://gerrit.wikimedia.org/r/1031107

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits