Remove setupSkinUserCss and doSetupSkinUserCss methods
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

These have been deprecated since 1.32 and sending hard warnings since 1.36

They can now be removed (finally) in 1.37

Details

	Subject	Repo	Branch	Lines +/-
	Remove doSetupSkinUserCss and setupSkinUserCss	mediawiki/core	master	+3 -31

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T282045 [GOAL] Deprecate and remove skin code in preparation for 1.37
		Resolved		Jdlrobson	T280610 Remove setupSkinUserCss and doSetupSkinUserCss methods

Event Timeline

Jdlrobson created this task.Apr 20 2021, 12:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2021, 12:40 AM

Jdlrobson assigned this task to ovasileva.May 5 2021, 7:12 PM

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva triaged this task as Medium priority.May 10 2021, 2:47 PM

ovasileva moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson moved this task from Triaged but Future to unsed on the Web-Team-Backlog board.Jun 11 2021, 9:04 PM

There are still quite a few skins that use these methods, but many of those skins are not compatible with MediaWiki 1.36 anyway, and this function has been deprecated since 1.32 so I think removing it is fine.
https://codesearch.wmcloud.org/search/?q=setupSkinUserCss&i=nope&files=&excludeFiles=&repos=

Am open to considering bumping this to 1.38 if that doesn't sit well with some people.

Am particularly interested in hearing input from Brickimedia.

Jdlrobson removed ovasileva as the assignee of this task.Jun 14 2021, 6:22 PM

Jdlrobson moved this task from Triaged but Future to unsed on the Web-Team-Backlog board.

Jdlrobson added a subscriber: ovasileva.

DannyS712 moved this task from Blocker to To deprecate or remove on the MW-1.37-release board.Jul 7 2021, 10:22 PM

Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.Jul 14 2021, 3:37 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

LGoto set the point value for this task to 2.Jul 20 2021, 5:07 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

In T280610#7152539, @Jdlrobson wrote:

Am particularly interested in hearing input from Brickimedia.

Hi, chiming in here on behalf of Brickimedia. :)

The Brickimedia GitHub organization and the repositories there are super duper legacy and haven't been used for production for years. The only relevant Brickimedia-developed, maintained and deployed skin is Refreshed (see also mw:Category:Skins by Brickimedia); its canonical source code repository is hosted on WMF gerrit. The legacy DeepSea skin has been implemented as a Vector theme (via the Theme extension) since almost precisely four years ago. Other skins in the Brickimedia repositories have been sunset/were never production-ready.

Thanks for the clarification @ashley Brickimedia skins are showing up in codesearch which is causing a lot of confusion (tracked in T286660). Refreshed is not impacted by this change so that's good to know!

Jdlrobson claimed this task.Jul 26 2021, 11:48 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 708185 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove doSetupSkinUserCss and setupSkinUserCss

https://gerrit.wikimedia.org/r/708185

gerritbot added a project: Patch-For-Review.Jul 26 2021, 11:53 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 26 2021, 11:54 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Krinkle edited projects, added Technical-Debt (Deprecation process); removed MW-1.37-release.Jul 27 2021, 12:22 AM

Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.

LGoto assigned this task to bwang.Jul 27 2021, 5:35 PM

Change 708185 merged by jenkins-bot: