Page MenuHomePhabricator
Create Task
Maniphest T280617

Wikisource OCR: Validate language codes
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Users can provide a list of languages that are in the image being OCRed, but these codes are not currently validated. Both engines have lists of supported languages, against which we can check the user input. We should show a friendly error when an unsupported language code is used (currently, Google will blindly accept invalid languages and return its best guess, and Tesseract will fail with a seemingly-unrelated message).

Acceptance Criteria:

  • Validate language input based on what is allowed in engine

Error copy:

This language is NOT supported by the OCR.

Related Objects

Event Timeline

Samwilson created this task.Apr 20 2021, 2:00 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptApr 20 2021, 2:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson updated the task description. (Show Details)Apr 20 2021, 2:00 AM
ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Apr 21 2021, 4:17 PM
ifried updated the task description. (Show Details)Apr 21 2021, 5:32 PM
ldelench_wmf set the point value for this task to 3.Apr 21 2021, 5:35 PM
ldelench_wmf moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
ldelench_wmf changed the point value for this task from 3 to 5.Apr 21 2021, 5:37 PM
ifried renamed this task from Validate language codes to Wikisource OCR: Validate language codes.Apr 21 2021, 6:00 PM
ifried moved this task from Up Next (June 3-21) to CommTech-Sprint-1 on the Community-Tech board.
ifried edited projects, added: Community-Tech (CommTech-Sprint-1); removed: Community-Tech.
• HMonroy claimed this task.Apr 21 2021, 8:18 PM
• HMonroy moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-1) board.
Samwilson mentioned this in T280848: Implement MVP of OCR in Wikisource extension.Apr 23 2021, 6:21 AM
• NRodriguez added subscribers: nayoub, • NRodriguez.Apr 26 2021, 7:23 PM

What's the process for providing error messages? Other than the error copy, do you need any other product design support for this copy and do we provide it on here? cc @nayoub

• NRodriguez updated the task description. (Show Details)Apr 26 2021, 8:51 PM

Error copy:

This language is NOT supported by the OCR.

Side note, do we have UX writing guidelines? cc @nayoub

• HMonroy added a comment.Apr 30 2021, 8:37 PM

PR: https://github.com/wikimedia/wikimedia-ocr/pull/23

• HMonroy moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-1) board.May 2 2021, 1:53 AM
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-1) board.May 3 2021, 7:51 PM
dom_walden subscribed.May 4 2021, 2:22 PM

@HMonroy @NRodriguez For the Google OCR engine, we now only treat as valid what Google considers "Supported languages".

The Google OCR engine technically supports more:

So it is no longer possible to enter a language like sco (Scots) or cy (Welsh) into Wikimedia OCR.

Do we want to support more languages?

A slightly related issue, I assume Google's list of supported languages might change in the future. Do we have a plan about how we are going to keep Wikimedia OCR up-to-date?

ifried subscribed.May 4 2021, 3:19 PM

Pinging @Samwilson, since I know Harumi is busy with some Editing team work :)

If we wanted to include support for the experimental & mapped languages, would this be possible? Could we create a ticket for it? Any thoughts/concerns?

• NRodriguez moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-1) board.May 4 2021, 6:20 PM
• NRodriguez moved this task from Done 🏁 to QA 🐛 on the Community-Tech (CommTech-Sprint-1) board.

Down to support more languages!

ifried mentioned this in T281913: Wikisource OCR: add language validation support to experimental & mapped languages.May 4 2021, 6:23 PM
Samwilson added a comment.May 4 2021, 11:12 PM
In T280617#7058055, @ifried wrote:

Pinging @Samwilson, since I know Harumi is busy with some Editing team work :)

If we wanted to include support for the experimental & mapped languages, would this be possible? Could we create a ticket for it? Any thoughts/concerns?

Yep, not hard to add the remaining language codes.

Keeping our list up to date is a different thing, and it doesn't look like there's any easy way to do it automatically: https://groups.google.com/g/cloud-vision-discuss/c/wkOZLwUTvYE/m/xpu-XQnMAQAJ

I guess we just keep it static, and try to revisit it every year or something.

dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-1) board.May 6 2021, 12:58 PM

If you enter an invalid language (like in this link), you get a nice error message such as:

The following language is not supported by the OCR engine: blah

The languages we accept varies depending on whether you choose Google or Tesseract.

I tested both engines, checking that we accept all the languages the respective engine supports (other than what we discussed in T280617#7057720 and some languages being incorrectly interpreted due to T281866).

If (the decision about) supporting other languages will be done in T281913, I will move this along.

Test Environment: https://ocr-test.wmcloud.org Version 0.1.0-5-gf2af8be

• NRodriguez closed this task as Resolved.May 24 2021, 3:34 PM

great job everyone! as always, thanks dom for QA notes as well!

ldelench_wmf moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-1) board.Jun 2 2021, 3:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits