Maniphest T280686

Remove WikibaseRepo getSettingsValueProvider
Closed, ResolvedPublic
Actions

Assigned To

Lucas_Werkmeister_WMDE

Authored By

	Lucas_Werkmeister_WMDE
	Apr 20 2021, 3:16 PM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

I think this method is best inlined into its one caller.

Details

	Subject	Repo	Branch	Lines +/-
	Remove WikibaseRepo::getSettingsValueProvider()	mediawiki/extensions/Wikibase	master	+3 -6

Customize query in gerrit

Related Objects

Mentioned In: T268600: Implement services through MediaWikiServices

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 20 2021, 3:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2021, 3:16 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 20 2021, 3:26 PM

Lucas_Werkmeister_WMDE claimed this task.Apr 20 2021, 4:18 PM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 681433 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo::getSettingsValueProvider()

https://gerrit.wikimedia.org/r/681433

gerritbot added a project: Patch-For-Review.Apr 20 2021, 4:23 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 20 2021, 4:23 PM

Change 681433 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseRepo::getSettingsValueProvider()

https://gerrit.wikimedia.org/r/681433

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 9:00 AM

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 21 2021, 9:02 AM

Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 9:10 AM

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Apr 21 2021, 3:49 PM