Page MenuHomePhabricator

Hard deprecate watchlist methods in WatchAction
Closed, ResolvedPublic

Description

Remove usages and hard deprecate the following WatchAction methods:

  • doWatch(): use WatchlistManager::addWatch() or WatchlistManager::addWatchIgnoringRights() instead
  • doUnwatch(): use WatchlistManager::removeWatch() instead
  • doWatchOrUnwatch(): use WatchlistManager::setWatch() instead

Usages in core have already been removed except for in WatchAction tests.

Wikimedia production extensions:

  • EntitySchema
  • LiquidThreads
  • MobileFrontend
  • Wikibase

Other bundled extensions:

  • ReplaceText (master compatibility policy)

Other extensions:

Core:

  • Hide deprecations in WatchAction tests
  • Hard deprecate doWatch(), doUnwatch(), and doWatchOrUnwatch()

Event Timeline

CCicalese_WMF renamed this task from Hard deprecate watchlist methods in User and WatchAction to Hard deprecate watchlist methods in WatchAction.Apr 26 2021, 6:10 PM
CCicalese_WMF triaged this task as Medium priority.
CCicalese_WMF updated the task description. (Show Details)

Change 683008 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/EntitySchema@master] Replace usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683008

Change 683009 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/LiquidThreads@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683009

Change 683010 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/MobileFrontend@master] Replace Usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683010

Change 683015 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/Wikibase@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683015

Change 683016 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/ReplaceText@master] Replace usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683016

Change 683017 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/extensions/BlueSpiceSocialWatch@master] Replace usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683017

Change 683017 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSocialWatch@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683017

Change 683009 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683009

Change 683008 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Replace usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683008

Change 683382 had a related patch set uploaded (by Cicalese; author: Cicalese):

[mediawiki/core@master] Hard deprecate watchlist methods and remove corresponding tests

https://gerrit.wikimedia.org/r/683382

Change 683395 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/EntitySchema@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683395

Change 683398 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/LiquidThreads@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683398

Change 683399 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/BlueSpiceSocialWatch@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683399

Change 683398 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683398

Change 683395 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683395

Change 683016 merged by jenkins-bot:

[mediawiki/extensions/ReplaceText@master] Replace usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683016

Change 683399 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSocialWatch@master] Bump required version of MediaWiki to 1.37+

https://gerrit.wikimedia.org/r/683399

Change 683010 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace Usage of deprecated WatchAction methods

https://gerrit.wikimedia.org/r/683010

Change 683015 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace usage of deprecated WatchAction/User watchlist methods

https://gerrit.wikimedia.org/r/683015

Change 683382 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate watchlist methods in WatchAction

https://gerrit.wikimedia.org/r/683382