Page MenuHomePhabricator
Create Task
Maniphest T280765

Remove WikibaseClient::getDefaultInstance()
Closed, ResolvedPublic
Actions

Description

After T280653: Move WikibaseClient PropertyParserFunctionRunner to service container, WikibaseClient will have no more non-static functions (other than its constructor). There should no longer be any need for anyone to obtain an instance of this class, and consequently we should remove all callers of the getDefaultInstance() method and then the method itself. (I assume most of those callers assign it to a variable that is unused by now, but which we didn’t remove earlier.)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+0 -39Remove WikibaseClient::getDefaultInstance()
mediawiki/extensions/Wikibasemaster+7 -30Remove inconsequential WikibaseClient::getDefaultInstance() calls
mediawiki/extensions/Wikibasemaster+0 -44Remove calls to WikibaseClient::getDefaultInstance( 'reset' )
mediawiki/extensions/ArticlePlaceholdermaster+0 -11Remove calls to WikibaseClient::getDefaultInstance( 'reset' )
mediawiki/extensions/ArticlePlaceholdermaster+0 -1Remove inconsequential WikibaseClient::getDefaultInstance() call
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 21 2021, 9:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 9:19 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 21 2021, 9:19 AM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 21 2021, 9:43 AM
Lucas_Werkmeister_WMDE claimed this task.Apr 21 2021, 10:11 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 21 2021, 10:47 AM

Change 681610 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove inconsequential WikibaseClient::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/681610

gerritbot added a project: Patch-For-Review.Apr 21 2021, 10:47 AM

Change 681611 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Remove inconsequential WikibaseClient::getDefaultInstance() call

https://gerrit.wikimedia.org/r/681611

gerritbot added a comment.Apr 21 2021, 10:48 AM

Change 681612 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681612

gerritbot added a comment.Apr 21 2021, 10:48 AM

Change 681613 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681613

gerritbot added a comment.Apr 21 2021, 10:48 AM

Change 681614 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient::getDefaultInstance()

https://gerrit.wikimedia.org/r/681614

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 21 2021, 10:50 AM
Lucas_Werkmeister_WMDE mentioned this in T280803: Remove WikibaseClient constructor.Apr 21 2021, 3:07 PM
gerritbot added a comment.Apr 21 2021, 3:19 PM

Change 681611 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Remove inconsequential WikibaseClient::getDefaultInstance() call

https://gerrit.wikimedia.org/r/681611

gerritbot added a comment.Apr 21 2021, 3:19 PM

Change 681613 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681613

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 4:00 PM
gerritbot added a comment.Apr 21 2021, 7:47 PM

Change 681610 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove inconsequential WikibaseClient::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/681610

gerritbot added a comment.Apr 21 2021, 7:48 PM

Change 681612 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681612

gerritbot added a comment.Apr 21 2021, 7:49 PM

Change 681614 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient::getDefaultInstance()

https://gerrit.wikimedia.org/r/681614

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 8:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 21 2021, 10:15 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL