Page MenuHomePhabricator

Remove WikibaseClient::getDefaultInstance()
Closed, ResolvedPublic

Description

After T280653: Move WikibaseClient PropertyParserFunctionRunner to service container, WikibaseClient will have no more non-static functions (other than its constructor). There should no longer be any need for anyone to obtain an instance of this class, and consequently we should remove all callers of the getDefaultInstance() method and then the method itself. (I assume most of those callers assign it to a variable that is unused by now, but which we didn’t remove earlier.)

Event Timeline

Change 681610 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove inconsequential WikibaseClient::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/681610

Change 681611 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Remove inconsequential WikibaseClient::getDefaultInstance() call

https://gerrit.wikimedia.org/r/681611

Change 681612 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681612

Change 681613 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681613

Change 681614 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient::getDefaultInstance()

https://gerrit.wikimedia.org/r/681614

Change 681611 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Remove inconsequential WikibaseClient::getDefaultInstance() call

https://gerrit.wikimedia.org/r/681611

Change 681613 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681613

Change 681610 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove inconsequential WikibaseClient::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/681610

Change 681612 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove calls to WikibaseClient::getDefaultInstance( 'reset' )

https://gerrit.wikimedia.org/r/681612

Change 681614 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove WikibaseClient::getDefaultInstance()

https://gerrit.wikimedia.org/r/681614