Page MenuHomePhabricator
Create Task
Maniphest T280771

Look into creating a service for resolving Item redirects on client
Closed, ResolvedPublic
Actions

Description

In order to implement T280758 in a non-hacky way, we need a service that resolves Item redirects, i.e. that, given an ItemId, returns the ItemId of its redirect target. There is an implementation of EntityRedirectLookup for the repo, but none for client. We also only need EntityRedirectLookup::getRedirectForEntityId (not getRedirectIds) so maybe EntityRedirectLookup needs to be split in two for this purpose.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Create RevisionBasedEntityRedirectTargetLookup for luamediawiki/extensions/Wikibasemaster+145 -42
Update wikibase/data-model-services from 5.3.0 to 5.4.0mediawiki/vendormaster+56 -29
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Apr 21 2021, 10:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 10:18 AM
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 21 2021, 11:02 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Apr 21 2021, 11:15 AM
Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.Apr 21 2021, 8:11 PM
Jakob_WMDE claimed this task.Apr 22 2021, 10:28 AM
gerritbot added a comment.Apr 23 2021, 1:39 PM

Change 682130 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/vendor@master] Update wikibase/data-model-services from 5.3.0 to 5.4.0

https://gerrit.wikimedia.org/r/682130

gerritbot added a project: Patch-For-Review.Apr 23 2021, 1:39 PM
gerritbot added a comment.Apr 23 2021, 2:08 PM

Change 682135 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Create RevisionBasedEntityRedirectTargetLookup for lua

https://gerrit.wikimedia.org/r/682135

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 23 2021, 3:05 PM
gerritbot added a comment.Apr 23 2021, 3:26 PM

Change 682130 merged by jenkins-bot:

[mediawiki/vendor@master] Update wikibase/data-model-services from 5.3.0 to 5.4.0

https://gerrit.wikimedia.org/r/682130

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 23 2021, 4:00 PM
Jakob_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 26 2021, 9:29 AM
Jakob_WMDE moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Apr 26 2021, 1:37 PM

Change 682135 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create RevisionBasedEntityRedirectTargetLookup for lua

https://gerrit.wikimedia.org/r/682135

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 2:10 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 26 2021, 3:20 PM
• amy_rc closed this task as Resolved.Apr 27 2021, 7:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits